[Backport 2] add configurable warmup iterations + iterations to http_logs workload #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…#448) Signed-off-by: Michael Oviedo <[email protected]> (cherry picked from commit 935a73f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
IanHoang
reviewed
Nov 11, 2024
| @@ -831,8 +831,8 @@ | |||
| { | |||
| "name": "match-all", | |||
| "operation": "default", | |||
| "warmup-iterations": 500, | |||
| "iterations": 100, | |||
| "warmup-iterations": {{ default_warmup_iterations or warmup_iterations | default(500) | tojson }}, | |||
There was a problem hiding this comment.
Some of these are using default_warmup_iterations and default_iterations. Could we update them to match the operation name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 935a73f from #448.