Update Big5 README Documentation #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SB in bash script Signed-off-by: Ian Hoang <[email protected]>
IanHoang
requested review from
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
IanHoang
added
backport 2
IanHoang
added
backport 7
gkamat
requested changes
Oct 20, 2024
Signed-off-by: Ian Hoang <[email protected]>
gkamat
approved these changes
Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script Signed-off-by: Ian Hoang <[email protected]> * Revise README Signed-off-by: Ian Hoang <[email protected]> --------- Signed-off-by: Ian Hoang <[email protected]> (cherry picked from commit b073177) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script Signed-off-by: Ian Hoang <[email protected]> * Revise README Signed-off-by: Ian Hoang <[email protected]> --------- Signed-off-by: Ian Hoang <[email protected]> (cherry picked from commit b073177) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script Signed-off-by: Ian Hoang <[email protected]> * Revise README Signed-off-by: Ian Hoang <[email protected]> --------- Signed-off-by: Ian Hoang <[email protected]> (cherry picked from commit b073177) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script Signed-off-by: Ian Hoang <[email protected]> * Revise README Signed-off-by: Ian Hoang <[email protected]> --------- Signed-off-by: Ian Hoang <[email protected]> (cherry picked from commit b073177) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script * Revise README --------- (cherry picked from commit b073177) Signed-off-by: Ian Hoang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script * Revise README --------- (cherry picked from commit b073177) Signed-off-by: Ian Hoang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script * Revise README --------- (cherry picked from commit b073177) Signed-off-by: Ian Hoang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script * Revise README --------- (cherry picked from commit b073177) Signed-off-by: Ian Hoang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
to joshpalis/opensearch-benchmark-workloads
that referenced
this pull request
Dec 18, 2024
* Add snippet documenting how to disable target_throughput when using OSB in bash script Signed-off-by: Ian Hoang <[email protected]> * Revise README Signed-off-by: Ian Hoang <[email protected]> --------- Signed-off-by: Ian Hoang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's unclear to users on how to disable
target_throughputin a bash script. The following blurb is added to the Big5 README to avoid confusion. We are also working to rephrase some of the target throughput documentation in the official OSB documentation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.