Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic search NOAA workload - move params to files, cleanup redandant operations #319

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Jun 13, 2024

Description

Doing some cleanup for semantic search workload based on NOAA dataset:

  • remove unused operations that are not related to hybrid query/search. those were added in initial version for testing purposes and are consuming resources (time and compute power) while not giving valuable info
  • refactor parameters into files, so now changes in cluster or index config (e.g. increasing num of replicas) are decoupled from command that runs the workload
  • update readme for workflow, mention param files

Issues Resolved

#291

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski
Copy link
Member Author

martin-gaievski commented Jun 13, 2024

Running CI tests through dummy PR opensearch-project/opensearch-benchmark#549, all tests passed

@martin-gaievski martin-gaievski marked this pull request as ready for review June 13, 2024 19:40
@VijayanB VijayanB added backport 2 Backport to the "2" branch backport 3 Backport to the "3" branch labels Jun 13, 2024
@VijayanB VijayanB merged commit e9d157b into opensearch-project:main Jun 14, 2024
4 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2024
…aa workload (#319)

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit e9d157b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2024
…aa workload (#319)

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit e9d157b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VijayanB pushed a commit that referenced this pull request Jun 14, 2024
…aa workload (#319) (#320)

(cherry picked from commit e9d157b)

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VijayanB pushed a commit that referenced this pull request Jun 14, 2024
…aa workload (#319) (#321)

(cherry picked from commit e9d157b)

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/opensearch-benchmark-workloads that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2 Backport to the "2" branch backport 3 Backport to the "3" branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants