Add missing quotes to big5 Jinja template #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Govind Kamat <[email protected]>
gkamat
requested review from
IanHoang,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
gkamat
added
backport 2
IanHoang
reviewed
Jun 10, 2024
| @@ -35,7 +35,7 @@ | |||
| "compressed-bytes": 53220934846, | |||
| "uncompressed-bytes": 943679382267 | |||
| } | |||
| {% elif corpus_size == 1000-full %} | |||
| {% elif corpus_size == "1000-full" %} | |||
| { | |||
| "source-file": "documents-1000-full.json.bz2", | |||
There was a problem hiding this comment.
Do we also need to include this in files.txt?
There was a problem hiding this comment.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Govind Kamat <[email protected]> (cherry picked from commit 411e304) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Govind Kamat <[email protected]> (cherry picked from commit 411e304) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Govind Kamat <[email protected]> (cherry picked from commit 411e304) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Govind Kamat <[email protected]> (cherry picked from commit 411e304) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
pushed a commit
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit 411e304) Signed-off-by: Govind Kamat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
pushed a commit
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit 411e304) Signed-off-by: Govind Kamat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
pushed a commit
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit 411e304) Signed-off-by: Govind Kamat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
pushed a commit
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit 411e304) Signed-off-by: Govind Kamat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
changed the title
harshavamsi
pushed a commit
to harshavamsi/opensearch-benchmark-workloads
that referenced
this pull request
Jul 16, 2024
Signed-off-by: Govind Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fix to big5 workload; missing quotes were causing subsequent corpus sizes in
workload.jsonto raise errors.Testing
Verified that all corpus sizes available are accepted and do not raise errors.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.