Add workloads for vector radial search #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
1 task
VijayanB
reviewed
Jun 19, 2024
vectorsearch/params/radial_search/add_radial_threshold_to_dataset.py
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Jun 19, 2024
vectorsearch/params/radial_search/add_radial_threshold_to_dataset.py
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Jun 19, 2024
vectorsearch/params/radial_search/add_radial_threshold_to_dataset.py
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Jun 19, 2024
Comment on lines
+12
to
21
| {% if query_k is defined %} | ||
| "k": {{ query_k }}, | ||
| {% endif %} | ||
| {% if query_max_distance is defined %} | ||
| "max_distance": {{ query_max_distance }}, | ||
| {% endif %} | ||
| {% if query_min_score is defined %} | ||
| "min_score": {{ query_min_score }}, | ||
| {% endif %} | ||
| "field" : "{{ target_field_name | default('target_field') }}", |
There was a problem hiding this comment.
what if none of them is defined or both is defined?
There was a problem hiding this comment.
Not sure if we can have the logic check in here, but we can add in OSB params validation process
There was a problem hiding this comment.
Let's call this out in README param section
There was a problem hiding this comment.
@junqiu-lei Please add this call out to the README
|
Do we have plan to support as corpus? |
Not yet, we can consider the support based on this workflow if needed |
VijayanB
reviewed
Jun 19, 2024
vectorsearch/params/radial_search/add_radial_threshold_to_dataset.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
|
Verified CI test by https://github.com/junqiu-lei/opensearch-benchmark/actions/runs/10115991636/job/27979552454?pr=1, all tests passed except: I think it's know issue also occurred in @finnroblin 's test and opensearch-project/opensearch-benchmark#364 (comment) |
VijayanB
approved these changes
Jul 30, 2024
Issue is because multi_terms does not exist in earlier versions of OpenSearch that integ tests use. We can disregard for now. |
IanHoang
added
backport 2
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Add workloads for vector radial search Signed-off-by: Junqiu Lei <[email protected]> * Add script to generate dataset for radial search Signed-off-by: Junqiu Lei <[email protected]> * Resolve feedback Signed-off-by: Junqiu Lei <[email protected]> * Move script to _tools folder Signed-off-by: Junqiu Lei <[email protected]> * update README.md Signed-off-by: Junqiu Lei <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit cf77622) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-3 3
# Navigate to the new working tree
pushd ../.worktrees/backport-3
# Create a new branch
git switch --create backport/backport-309-to-3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf77622de87b6c0326fc83d758009af99d97923a
# Push it to GitHub
git push --set-upstream origin backport/backport-309-to-3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-3Then, create a pull request where the |
gkamat
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Add workloads for vector radial search * Add script to generate dataset for radial search * Resolve feedback * Move script to _tools folder * update README.md --------- (cherry picked from commit cf77622) Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add workloads for vector radial search support
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.