Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field name from getTime to time in GetStats schema #785

Closed

Conversation

hye-on
Copy link
Contributor

@hye-on hye-on commented Jan 13, 2025

Description

Fixed response schema in GetStats to rename getTime to time field to maintain consistency across the API schema.

Issues Resolved

Related to opensearch-project/OpenSearch#16894

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: hye-on <[email protected]>
@dblock
Copy link
Member

dblock commented Jan 13, 2025

Thanks! Given that this is a breaking change the way to introduce it is to add time in OpenSearch and deprecate getTime, and do the same here in the spec after that PR is merged into OpenSearch core.

@hye-on
Copy link
Contributor Author

hye-on commented Jan 14, 2025

@dblock
I understand. I will first add time field and deprecate getTime in OpenSearch, then create a new PR to update the API specification after the OpenSearch changes are merged.

Closing this PR for now. Thanks for the guidance! :)

@hye-on hye-on closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants