-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed /_search/scroll/{scroll_id}, missing search tests. #732
Conversation
a56c09a
to
caa8b35
Compare
Changes AnalysisCommit SHA: b3745d4 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12361446786/artifacts/2328624342 API Coverage
|
Spec Test Coverage Analysis
|
ee15f81
to
19e3239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking perfect as usual. It looks like the OS version might need to be updated in one of the tests.
f746863
to
03cbe27
Compare
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
…id}. Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
03cbe27
to
b3745d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM! Great job
…project#732) * Fixed /_search/scroll. Signed-off-by: dblock <[email protected]> * Added tests for GET and POST /_search. Signed-off-by: dblock <[email protected]> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <[email protected]> * Added missing _search/point_in_time tests. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]>
…project#732) * Fixed /_search/scroll. Signed-off-by: dblock <[email protected]> * Added tests for GET and POST /_search. Signed-off-by: dblock <[email protected]> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <[email protected]> * Added missing _search/point_in_time tests. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: Nathalie Jonathan <[email protected]>
Description
/_search/scroll/{scroll_id}
deprecated variant does not requirescroll_id
in the body because it's already in the path.GET
andPOST /_search
.GET /_search/pipeline
andDELETE /_search/pipeline/{id}
._search/point_in_time
.Issues Resolved
Part of #663.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.