Add models for the /_remotestore/_restore API endpoint
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested review from
abhivka7,
dblock,
harshavamsi,
pgtgrly,
sachetalva,
nhtruong and
VachaShah
as code owners
|
@Xtansia can we also add tests here? |
|
@harshavamsi Have added a test case |
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
feat/remotestore
branch
from
1266605 to
d874905
Compare
nhtruong
approved these changes
Feb 8, 2023
VachaShah
reviewed
Feb 9, 2023
| @suppress(["HttpUriConflict"]) | ||
| @http(method: "POST", uri: "/_remotestore/_restore") | ||
| @documentation("Restore one or more indices from a remote backup.") | ||
| operation PostRemoteStoreRestore{ |
There was a problem hiding this comment.
Are the names of the operation and structures inline with what we would want in the generated code? Or do they need to be changed?
There was a problem hiding this comment.
They're named to match the naming scheme of the rest of the specs in the repo. Naming (or encoding friendly names as metadata similar to #73) will likely be a bigger issue, but hard to solve in advance until we get to the point of actually generating parts of a client from these.
VachaShah
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add's models for the
/_remotestore/_restoreAPI endpointAs seen here,
acceptedmay be set in the response instead ofremote_store, unsure of exact causal path however.Issues Resolved
Resolves #69
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.