Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests, fixes ExplanationDetail/value. #685

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 20, 2024

Description

  • PUT /{index}/_block/{block}
  • PUT /{index}/_clone/{target}
  • GET and POST /{index}/_explain/{id}.
  • Fixes ExplanationDetail type of value (an int32 is also an int64).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock changed the title More tests More tests, fixes ExplanationDetail/value. Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Changes Analysis

Commit SHA: 76d124d
Comparing To SHA: 1ce89fe

API Changes

Summary

└─┬Paths
  └─┬/{index}/_explain/{id}
    ├─┬GET
    │ └─┬Responses
    │   └─┬200
    │     └─┬application/json
    │       └─┬Schema
    │         └──[➕] properties (28519:15)
    └─┬POST
      └─┬Responses
        └─┬200
          └─┬application/json
            └─┬Schema
              └──[➕] properties (28519:15)

Document Element Total Changes Breaking Changes
paths 2 0
  • Total Changes: 2
  • Additions: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11942141965/artifacts/2215625132

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

@dblock dblock force-pushed the more-tests branch 2 times, most recently from a428c1c to d104f32 Compare November 20, 2024 21:34
Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
528 370 (70.08 %)

@dblock dblock merged commit e3dcb7a into opensearch-project:main Nov 20, 2024
26 checks passed
@dblock dblock deleted the more-tests branch November 20, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants