Merge feature/openapi/final into Main #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtruong
requested review from
dblock,
harshavamsi,
pgtgrly,
sachetalva,
Xtansia and
VachaShah
as code owners
- Removed Smithy: - Removed Smithy models (`model` folder) - Removed Gradle - Removed legacy test framework - Removed build-openapi-specs workflow - Added Editable OpenAPI spec: - Added multi-file OpenApi spec (`spec` folder) - Added a tool to merge multi-file spec into single-file spec - Added build-single-file-specs workflow - Updated Documents ## Adding Request and Response Bodies The OpenAPI spec has also been updated with the request and response bodies that we extracted from ElasticSearch OpenAPI spec. This is done within the same PR as the native OpenAPI switch because we also used the ElasticSearch OpenAPI spec to map the query/path schemas to the schemas of many components in the bodies. Signed-off-by: Theo Truong <[email protected]>
nhtruong
force-pushed
the
feature/openapi/final
branch
from
8f19f16 to
04f3e2f
Compare
dblock
previously approved these changes
Mar 27, 2024
|
@Xtansia take a look, merge? |
Signed-off-by: Theo Truong <[email protected]>
Xtansia
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Everything looks good generally, I have a similar concern to @dblock regarding checking in the built spec, but agree it can wait until after. Only issue I noticed was that there's a couple remaining references to xpack that should be tidied up
Signed-off-by: Theo Truong <[email protected]>
Signed-off-by: Theo Truong <[email protected]>
|
@dblock the API Coverage workflow is still being triggered from main branch. We will have to disable the workflow in the repo settings to get this merged. |
That's ok. |
dblock
approved these changes
Apr 1, 2024
|
@Xtansia good with you? |
Xtansia
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching over to native OpenAPI:
modelfolder)specfolder)Adding Request and Response Bodies
The OpenAPI spec has also been updated with the request and response bodies that we extracted from ElasticSearch OpenAPI spec. This is done within the same PR as the native OpenAPI switch because we also used the ElasticSearch OpenAPI spec to map the query/path schemas to the schemas of many components in the bodies.
Reviewers: It's easier to review this PR like reviewing a new repo by inspecting the feature branch
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.