Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: auto chart added #913

Merged
merged 37 commits into from
Sep 29, 2022

Conversation

ramneet-persistent
Copy link
Contributor

@ramneet-persistent ramneet-persistent commented Aug 3, 2022

[Feature] Stats chart

  • only auto chart type mode is integrated (will raise separate PR for horizontal/text mode chart)
  • two sync with query manager

Issues Resolved

#835
#1013

@ramneet-persistent ramneet-persistent requested a review from a team as a code owner August 3, 2022 06:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #913 (f824b39) into main (08a8d82) will decrease coverage by 0.70%.
The diff coverage is 20.54%.

@@             Coverage Diff              @@
##               main     #913      +/-   ##
============================================
- Coverage     54.31%   53.61%   -0.71%     
  Complexity      291      291              
============================================
  Files           277      280       +3     
  Lines          9106     9307     +201     
  Branches       2034     2132      +98     
============================================
+ Hits           4946     4990      +44     
- Misses         3990     4147     +157     
  Partials        170      170              
Flag Coverage Δ
dashboards-observability 47.58% <20.54%> (-0.77%) ⬇️
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboards-observability/common/constants/shared.ts 100.00% <ø> (ø)
.../common/query_manager/ast/builder/stats_builder.ts 0.00% <0.00%> (ø)
...mmon/query_manager/ast/expression/AggregateTerm.ts 0.00% <0.00%> (ø)
...bility/common/query_manager/ast/expression/span.ts 0.00% <0.00%> (ø)
...helpers/ppl_docs/language_structure/identifiers.ts 100.00% <ø> (ø)
...fig_panes/config_controls/config_chart_options.tsx 1.36% <0.00%> (-0.36%) ⬇️
...config_panes/config_controls/config_thresholds.tsx 2.63% <0.00%> (-0.23%) ⬇️
...omponents/visualizations/charts/lines/line_type.ts 100.00% <ø> (ø)
.../components/visualizations/charts/maps/heatmap.tsx 6.25% <0.00%> (ø)
...ponents/visualizations/charts/maps/heatmap_type.ts 100.00% <ø> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ramneet-persistent ramneet-persistent marked this pull request as draft August 10, 2022 06:39
@ramneet-persistent ramneet-persistent force-pushed the feature/stats branch 6 times, most recently from 85fad98 to 051d04f Compare August 17, 2022 12:46
@ramneet-persistent ramneet-persistent force-pushed the feature/stats branch 2 times, most recently from 8d9662f to b0df6d4 Compare August 23, 2022 10:43
@ramneet-persistent ramneet-persistent marked this pull request as ready for review August 30, 2022 15:48
@ramneet-persistent ramneet-persistent force-pushed the feature/stats branch 2 times, most recently from a86e813 to b13c74d Compare September 19, 2022 12:17
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
@mengweieric mengweieric merged commit bdf5291 into opensearch-project:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants