-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line chart: Legend, Chart styles features implementation on config panel - 697 #784
Line chart: Legend, Chart styles features implementation on config panel - 697 #784
Conversation
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx
…from chartOption Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #784 +/- ##
============================================
- Coverage 58.20% 58.04% -0.17%
Complexity 291 291
============================================
Files 244 248 +4
Lines 8018 8089 +71
Branches 1647 1671 +24
============================================
+ Hits 4667 4695 +28
- Misses 3177 3220 +43
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
<EuiSpacer size="s" /> | ||
<div style={{ width: "fit-content" }}> | ||
<EuiButtonGroup | ||
id={uniqueId('button-select-')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use html id generator moving forward for ids, and gradually replace all other uniqueId with that. Guide, html id generator
This PR contains some similar things from this PR, could you refer to that PR and address the similar things? thanks |
As added these changes in Sprint1 PR and it's merged now in main. So, closing this PR. |
Description
[Describe what this change achieves]
The below features are implemented in the config panel in this PR:
Legend:
Chart styles:
Here are the visuals and implementation of new Data configs on the Line chart as per the issue #697
#697 (comment)
Issues Resolved
[List any issues this PR will resolve]
#697
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@spattnaik @abasatwar