-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend and Chart styles features implementation for line chart on config panel #697 #765
Legend and Chart styles features implementation for line chart on config panel #697 #765
Conversation
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx
…from chartOption Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Adding @spattnaik @abasatwar for reference. |
Codecov Report
@@ Coverage Diff @@
## main #765 +/- ##
=============================================
+ Coverage 58.19% 71.87% +13.68%
Complexity 291 291
=============================================
Files 242 42 -200
Lines 7982 2311 -5671
Branches 1632 240 -1392
=============================================
- Hits 4645 1661 -2984
+ Misses 3163 509 -2654
+ Partials 174 141 -33
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Eugene Lee <[email protected]>
Signed-off-by: Eugene Lee <[email protected]>
Signed-off-by: Eugene Lee <[email protected]>
…pensearch-project#775) * Added cypress test cases for tooltip and search engine on Trace dashboard Signed-off-by: Pratibha Pandey <[email protected]> * Added test cases for filters Signed-off-by: Pratibha Pandey <[email protected]> * Added cypress test cases for tooltip and search engine on Trace dashboard Signed-off-by: Pratibha Pandey <[email protected]> * Added test cases for filters Signed-off-by: Pratibha Pandey <[email protected]> * Added test cases for Service page in Trace analytics Signed-off-by: Pratibha Pandey <[email protected]> * Added Cypress test cases for trace analytics services spans table Signed-off-by: Deepak Nevde <[email protected]> * Cypress test case for Traces Signed-off-by: Nidhi Singhai <[email protected]> * Cypress test case for Traces Updated Signed-off-by: Nidhi Singhai <[email protected]> * Worked on review comments Signed-off-by: Pratibha Pandey <[email protected]> Co-authored-by: Deepak Nevde <[email protected]> Co-authored-by: Nidhi Singhai <[email protected]>
…project#736) * rendered default axes selected and added error toasts on Save and Apply click if invalid value option selected Signed-off-by: rinku-kumar-psl <[email protected]> * Cypress changes for error toasts on invalid value options selected Signed-off-by: rinku-kumar-psl <[email protected]> * added constant VIZ_CONTAIN_XY_AXIS for x, y value axis Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx # dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]> # Conflicts: # dashboards-observability/public/components/visualizations/charts/lines/line.tsx
…from chartOption Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
…-kumar-psl/observability into feature/line-chart-new-configs-697
Creating a new PR for these changes as after rebasing few main branch commits appear here. |
Description
[Describe what this change achieves]
The below features are implemented in the config panel in this PR:
Legend:
Chart styles:
Here are the visuals and implementation of new Data configs on the Line chart as per the issue #697
#697 (comment)
Issues Resolved
[List any issues this PR will resolve]
#697
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.