Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend and Chart styles features implementation for line chart on config panel #697 #765

Conversation

rinku-kumar-psl
Copy link
Contributor

Description

[Describe what this change achieves]

The below features are implemented in the config panel in this PR:

Legend:

  • Show Legend
  • Position

Chart styles:

  • Mode (Line, Bars, Points, Lines+Points)
  • Interpolation (Linear, Smooth, Step Before, Step After)
  • Line Width
  • Fill Opacity
  • Point Size

Here are the visuals and implementation of new Data configs on the Line chart as per the issue #697
#697 (comment)

Issues Resolved

[List any issues this PR will resolve]
#697

Check List

  • New functionality includes above listed Legend and Chart styles features in the Data config panel.
    • All tests that pass, including unit test, and integration test, except a few test cases, are failing at my end which is not related to this functionality.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>
@rinku-kumar-psl rinku-kumar-psl requested a review from a team as a code owner May 25, 2022 09:29
@rinku-kumar-psl
Copy link
Contributor Author

Adding @spattnaik @abasatwar for reference.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #765 (f8a4837) into main (b23946d) will increase coverage by 13.68%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #765       +/-   ##
=============================================
+ Coverage     58.19%   71.87%   +13.68%     
  Complexity      291      291               
=============================================
  Files           242       42      -200     
  Lines          7982     2311     -5671     
  Branches       1632      240     -1392     
=============================================
- Hits           4645     1661     -2984     
+ Misses         3163      509     -2654     
+ Partials        174      141       -33     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hboards-observability/common/constants/explorer.ts
...ashboards-observability/common/constants/shared.ts
...cs/components/config_components/service_config.tsx
...tics/components/config_components/trace_config.tsx
...onents/application_analytics/components/create.tsx
...components/application_analytics/helpers/utils.tsx
...ic/components/custom_panels/custom_panel_table.tsx
...lic/components/custom_panels/custom_panel_view.tsx
...ponents/custom_panels/helpers/modal_containers.tsx
...tom_panels/panel_modules/panel_grid/panel_grid.tsx
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23946d...f8a4837. Read the comment docs.

eugenesk24 and others added 14 commits May 25, 2022 14:25
…pensearch-project#775)

* Added cypress test cases for tooltip and search engine on Trace dashboard

Signed-off-by: Pratibha Pandey <[email protected]>

* Added test cases for filters

Signed-off-by: Pratibha Pandey <[email protected]>

* Added cypress test cases for tooltip and search engine on Trace dashboard

Signed-off-by: Pratibha Pandey <[email protected]>

* Added test cases for filters

Signed-off-by: Pratibha Pandey <[email protected]>

* Added test cases for Service page in Trace analytics

Signed-off-by: Pratibha Pandey <[email protected]>

* Added Cypress test cases for trace analytics services spans table

Signed-off-by: Deepak Nevde <[email protected]>

* Cypress test case for Traces

Signed-off-by: Nidhi Singhai <[email protected]>

* Cypress test case for Traces Updated

Signed-off-by: Nidhi Singhai <[email protected]>

* Worked on review comments

Signed-off-by: Pratibha Pandey <[email protected]>

Co-authored-by: Deepak Nevde <[email protected]>
Co-authored-by: Nidhi Singhai <[email protected]>
…project#736)

* rendered default axes selected and added error toasts on Save and Apply click if invalid value option selected

Signed-off-by: rinku-kumar-psl <[email protected]>

* Cypress changes for error toasts on invalid value options selected

Signed-off-by: rinku-kumar-psl <[email protected]>

* added constant VIZ_CONTAIN_XY_AXIS for x, y value axis

Signed-off-by: rinku-kumar-psl <[email protected]>
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
@rinku-kumar-psl
Copy link
Contributor Author

Creating a new PR for these changes as after rebasing few main branch commits appear here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants