Modularize event Analytics live tail and fix bug #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
kavithacm
changed the title
joshuali925
reviewed
Apr 13, 2022
dashboards-observability/public/components/common/live_tail/live_tail_button.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/common/live_tail/live_tail_button.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/explorer/explorer.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/.cypress/integration/event_analytics.spec.js
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/explorer/explorer.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/explorer/explorer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
joshuali925
previously approved these changes
Apr 13, 2022
dashboards-observability/public/components/common/live_tail/live_tail_button.tsx
Outdated
Show resolved
Hide resolved
davidcui1225
previously approved these changes
Apr 13, 2022
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
kavithacm
dismissed stale reviews from davidcui1225 and joshuali925
via
1a25d60
joshuali925
previously approved these changes
Apr 13, 2022
mengweieric
reviewed
Apr 13, 2022
dashboards-observability/public/components/common/live_tail/live_tail_button.test.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/explorer/explorer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #647 +/- ##
=============================================
+ Coverage 59.46% 76.60% +17.13%
Complexity 283 283
=============================================
Files 236 38 -198
Lines 7735 2154 -5581
Branches 1552 228 -1324
=============================================
- Hits 4600 1650 -2950
+ Misses 2963 363 -2600
+ Partials 172 141 -31
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
mengweieric
approved these changes
Apr 18, 2022
| import { LiveTailButton, StopLiveButton } from '../live_tail_button'; | ||
| import { waitFor } from '@testing-library/dom'; | ||
|
|
||
| describe('Live tail button', () => { |
There was a problem hiding this comment.
I believe the describe should not be indented, can we reduce the indent here?
There was a problem hiding this comment.
yeah okay, one more PR is yet to come, will include the change in that
davidcui1225
approved these changes
Apr 18, 2022
eugenesk24
pushed a commit
to eugenesk24/trace-analytics
that referenced
this pull request
Jun 6, 2022
) Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kavitha Conjeevaram Mohan [email protected]
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.