Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated node dependencies #620

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

enzyme-adapter-react-16 and eslint are dependencies of core dashboards, removing them to avoid possible conflicts

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner April 4, 2022 17:23
@codecov-commenter
Copy link

Codecov Report

Merging #620 (95254fa) into main (fbab17e) will increase coverage by 21.88%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #620       +/-   ##
=============================================
+ Coverage     54.71%   76.60%   +21.88%     
  Complexity      283      283               
=============================================
  Files           240       38      -202     
  Lines          7777     2154     -5623     
  Branches       1633      228     -1405     
=============================================
- Hits           4255     1650     -2605     
+ Misses         3348      363     -2985     
+ Partials        174      141       -33     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/common/helpers/ppl_docs/functions/string.ts
...e_analytics/components/common/helper_functions.tsx
...ace_analytics/requests/queries/services_queries.ts
...tics/components/common/plots/service_map_scale.tsx
...ig_editor/config_controls/config_chart_options.tsx
...ts/explorer/visualizations/drag_drop/drag_drop.tsx
...components/common/helpers/ppl_docs/commands/top.ts
...cs/components/config_components/service_config.tsx
...common/debounced_component/debounced_component.tsx
...-observability/common/constants/trace_analytics.ts
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbab17e...95254fa. Read the comment docs.

Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 merged commit 82c3d24 into opensearch-project:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants