Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpha1 qualifiers for dashboards plugin #616

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

closes #577

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner March 30, 2022 20:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #616 (b0b23bb) into main (5f2294c) will increase coverage by 22.05%.
The diff coverage is n/a.

❗ Current head b0b23bb differs from pull request most recent head 06f4cd1. Consider uploading reports for the commit 06f4cd1 to get more accurate results

@@              Coverage Diff              @@
##               main     #616       +/-   ##
=============================================
+ Coverage     54.54%   76.60%   +22.05%     
  Complexity      283      283               
=============================================
  Files           239       38      -201     
  Lines          7795     2154     -5641     
  Branches       1605      228     -1377     
=============================================
- Hits           4252     1650     -2602     
+ Misses         3371      363     -3008     
+ Partials        172      141       -31     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y/public/components/explorer/slices/query_slice.ts
...onents/explorer/visualizations/lens_field_icon.tsx
...nts/common/helpers/ppl_docs/functions/condition.ts
...s/trace_analytics/components/traces/trace_view.tsx
...e_analytics/components/traces/flyout_list_item.tsx
...mponents/common/helpers/ppl_docs/commands/dedup.ts
...n/helpers/ppl_docs/language_structure/datatypes.ts
...isualizations/charts/financial/gauge/gauge_type.ts
.../components/visualizations/charts/maps/heatmap.tsx
...omponents/common/helpers/ppl_docs/commands/sort.ts
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2294c...06f4cd1. Read the comment docs.

Signed-off-by: Joshua Li <[email protected]>
This reverts commit b0b23bb.

Signed-off-by: Joshua Li <[email protected]>
@@ -1,6 +1,6 @@
{
"id": "observabilityDashboards",
"version": "2.0.0.0",
"version": "2.0.0.0-alpha1",
"opensearchDashboardsVersion": "2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this correspond to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin version and compatible dashboards version

Copy link
Member

@vmmusings vmmusings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joshuali925 joshuali925 merged commit 84e56a2 into opensearch-project:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for build version qualifiers.
4 participants