Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize and cleanup traces #601

Merged

Conversation

eugenesk24
Copy link
Contributor

Description

  • Clean up and modularize traces
  • Add cypress tests for breadcrumbs and table sorting

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eugenesk24 eugenesk24 requested a review from a team as a code owner March 21, 2022 21:32
@eugenesk24 eugenesk24 marked this pull request as draft March 21, 2022 21:32
@codecov-commenter
Copy link

Codecov Report

Merging #601 (33138fa) into main (af54d6a) will increase coverage by 0.04%.
The diff coverage is 68.57%.

@@             Coverage Diff              @@
##               main     #601      +/-   ##
============================================
+ Coverage     53.32%   53.37%   +0.04%     
  Complexity      271      271              
============================================
  Files           238      239       +1     
  Lines          7748     7736      -12     
  Branches       1581     1566      -15     
============================================
- Hits           4132     4129       -3     
+ Misses         3421     3414       -7     
+ Partials        195      193       -2     
Flag Coverage Δ
dashboards-observability 46.14% <68.57%> (+0.04%) ⬆️
opensearch-observability 72.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trace_analytics/components/dashboard/dashboard.tsx 100.00% <ø> (ø)
...s/trace_analytics/components/services/services.tsx 100.00% <ø> (ø)
...nents/trace_analytics/components/traces/traces.tsx 100.00% <ø> (+35.48%) ⬆️
...trace_analytics/components/traces/traces_table.tsx 69.56% <66.66%> (+6.29%) ⬆️
...ace_analytics/components/traces/traces_content.tsx 70.00% <70.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af54d6a...33138fa. Read the comment docs.

@eugenesk24 eugenesk24 marked this pull request as ready for review March 21, 2022 23:08
@eugenesk24 eugenesk24 merged commit ed3a3bd into opensearch-project:main Mar 23, 2022
@eugenesk24 eugenesk24 deleted the modularize-and-cleanup-traces branch March 23, 2022 22:37
eugenesk24 added a commit to eugenesk24/trace-analytics that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants