Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize service and fix issues #595

Merged

Conversation

eugenesk24
Copy link
Contributor

@eugenesk24 eugenesk24 commented Mar 17, 2022

Signed-off-by: Eugene Lee [email protected]

Description

Removes unnecessary props from Service component:

  • appId: was used for breadcrumbs
  • appName: was used for breadcrumbs
  • openServiceFlyout: was used for the service table's name column action
  • switchToTrace: was used for the service table's trace column action
  • switchToEditViz: was used to clear saved object id for log events tab, moved to application component

Add more modular props to Service component:

  • childBreadcrumbs (replaces appId/appName)
  • nameColumnAction (replaces openServiceFlyout)
  • traceColumnAction (replaces switchToTrace)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eugene Lee <[email protected]>
@eugenesk24 eugenesk24 requested a review from a team as a code owner March 17, 2022 22:03
@davidcui1225
Copy link
Contributor

Can you add a PR description of the changes?

@eugenesk24 eugenesk24 merged commit af54d6a into opensearch-project:main Mar 18, 2022
@eugenesk24 eugenesk24 deleted the modularize-and-cleanup-services branch March 18, 2022 20:50
eugenesk24 added a commit to eugenesk24/trace-analytics that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants