Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint and modularize dashboard #583

Merged
merged 10 commits into from
Mar 17, 2022

Conversation

eugenesk24
Copy link
Contributor

@eugenesk24 eugenesk24 commented Mar 16, 2022

Description

  • Small lint fixes to clean up errors
  • Modularize dashboards
  • Fix breadcrumb link
  • Set edit visualization id to empty on tab change instead of at the render of other components

Issues Resolved

Breadcrumb link was broken in app analytics

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eugenesk24 eugenesk24 requested a review from a team as a code owner March 16, 2022 20:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #583 (b904d48) into main (87fb423) will increase coverage by 19.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #583       +/-   ##
=============================================
+ Coverage     53.24%   72.33%   +19.08%     
  Complexity      271      271               
=============================================
  Files           236       38      -198     
  Lines          7779     2136     -5643     
  Branches       1611      236     -1375     
=============================================
- Hits           4142     1545     -2597     
+ Misses         3439      429     -3010     
+ Partials        198      162       -36     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 72.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/application_analytics/components/create.tsx
...ic/components/custom_panels/custom_panel_table.tsx
...lic/components/custom_panels/custom_panel_view.tsx
...trace_analytics/components/dashboard/dashboard.tsx
...ace_analytics/components/services/service_view.tsx
...s/trace_analytics/components/services/services.tsx
...s/trace_analytics/components/traces/trace_view.tsx
...nents/trace_analytics/components/traces/traces.tsx
...onents/trace_analytics/requests/request_handler.ts
...ces/saved_objects/event_analytics/saved_objects.ts
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fb423...b904d48. Read the comment docs.

Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this change be tested with Cypress? Also, the frontend Observability workflow is failing.

Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -60,7 +60,7 @@ export const App = ({
chrome={chrome}
http={http}
notifications={notifications}
parentBreadcrumb={parentBreadcrumb}
parentBreadcrumbs={[parentBreadcrumb]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to the PR but i never understood why parentBreadcrumb needs to be passed through props previously, it's just a constant

const parentBreadcrumb = {
text: observabilityTitle,
href: `${observabilityID}#/`,
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's to be able to keep the previous breadcrumbs and extend with the new ones for each component.

@eugenesk24 eugenesk24 merged commit 7958e72 into opensearch-project:main Mar 17, 2022
@eugenesk24 eugenesk24 deleted the cleanup-and-modularize branch March 17, 2022 17:44
eugenesk24 added a commit to eugenesk24/trace-analytics that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants