Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline repo permissions code-owners and maintainers #1439

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Feb 28, 2023

Description

Baseline repo permissions code-owners and maintainers

Issues Resolved

Fix #1407
Fix #1460

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho derek-ho requested a review from a team as a code owner February 28, 2023 15:49
CODEOWNERS Outdated
@@ -0,0 +1,2 @@
# This should match the owning team set up in https://github.com/orgs/opensearch-project/teams
* @pjfitzgibbons @anirudha @nknize @ps48 @kavithacm @derek-ho @joshuali925 @zhongnansu @dai-chen @sejli @YANG-DB @davidcui1225 @rupal-bq @CEHENKLE @mengweieric @eugenesk24 @vamsi-amazon @kavck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing Swiddis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he was granted access to the repo as a contributor using the standard process

@@ -6,13 +6,14 @@ This document contains a list of maintainers in this repo. See [opensearch-proje

| Maintainer | GitHub ID | Affiliation |
| ----------------- | ------------------------------------------------- | ----------- |
| David Cui | [davidcui1225](https://github.com/davidcui1225) | Amazon |
| Eric Wei | [mengweieric](https://github.com/mengweieric) | Amazon |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing Swiddis

@YANG-DB YANG-DB self-requested a review March 14, 2023 21:09
Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho added the documentation Improvements or additions to documentation label Mar 15, 2023
| Rupal Mahajan | [rupal-bq](https://github.com/rupal-bq) | Amazon |
| Derek Ho | [derek-ho](https://github.com/derek-ho) | Amazon |
| Lior Perry | [YANG-DB](https://github.com/YANG-DB) | Amazon |
| Peter Fitzgibbons | [pjfitzgibbons](https://github.com/pjfitzgibbons) | Amazon |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing existing maintainers ?

Signed-off-by: Derek Ho <[email protected]>
ps48
ps48 previously approved these changes Mar 31, 2023
rupal-bq
rupal-bq previously approved these changes Mar 31, 2023
@derek-ho derek-ho dismissed stale reviews from rupal-bq and ps48 via afe551e April 25, 2023 18:23
@bbarani
Copy link
Member

bbarani commented Apr 25, 2023

Ready to merge. Maintainers have been added. This CODEOWNERS file is valid.

@derek-ho derek-ho merged commit 305decf into opensearch-project:main Apr 26, 2023
@derek-ho derek-ho deleted the baseline branch April 26, 2023 13:49
derek-ho added a commit to derek-ho/observability that referenced this pull request May 2, 2023
…ject#1439)

* add codeowners and baseline permissions

Signed-off-by: Derek Ho <[email protected]>

* update codeowners

Signed-off-by: Derek Ho <[email protected]>

* fix up file

Signed-off-by: Derek Ho <[email protected]>

* update codeowners and maintainers

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]Update Maintainers List Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
7 participants