Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove front end workflow and code #1362

Merged
merged 4 commits into from
Jan 6, 2023
Merged

remove front end workflow and code #1362

merged 4 commits into from
Jan 6, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jan 3, 2023

Signed-off-by: Derek Ho [email protected]

Description

Remove front end code from this backend code base, front end code has been moved to https://github.com/opensearch-project/dashboards-observability

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #1362 (39f8e63) into 2.x (042846e) will increase coverage by 28.21%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.x    #1362       +/-   ##
=============================================
+ Coverage     41.89%   70.10%   +28.21%     
  Complexity      315      315               
=============================================
  Files           302       46      -256     
  Lines         17849     2482    -15367     
  Branches       4332      253     -4079     
=============================================
- Hits           7477     1740     -5737     
+ Misses        10199      600     -9599     
+ Partials        173      142       -31     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 70.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/trace_analytics/requests/request_handler.ts
...mponents/visualizations/assets/chart_datatable.tsx
...components/plotly_viz_editor/plotly_viz_editor.tsx
..._analytics/components/common/plots/service_map.tsx
...ace_analytics/components/traces/traces_content.tsx
...components/visualizations/charts/text/text_type.ts
...c/components/metrics/redux/slices/metrics_slice.ts
...ponents/visualizations/charts/maps/treemap_type.ts
...ty/public/components/metrics/view/metrics_grid.tsx
...trace_analytics/requests/queries/traces_queries.ts
... and 119 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@derek-ho
Copy link
Collaborator Author

derek-ho commented Jan 3, 2023

@gaiksaya @zelinh I will wait for your go ahead before merging in this PR to get rid of front end code

@derek-ho derek-ho marked this pull request as ready for review January 5, 2023 16:55
@derek-ho derek-ho requested a review from a team as a code owner January 5, 2023 16:55
Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derek-ho I think you should be promoting the [opensearch-observability] folder content to be in the root level

@derek-ho
Copy link
Collaborator Author

derek-ho commented Jan 5, 2023

@derek-ho I think you should be promoting the [opensearch-observability] folder content to be in the root level

Done, thanks for catching it! @YANG-DB can you take another look?

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho merged commit e7dea87 into opensearch-project:2.x Jan 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1362-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e7dea87b2008094be7701250547cc02bbb2ca649
# Push it to GitHub
git push --set-upstream origin backport/backport-1362-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1362-to-main.

derek-ho added a commit to derek-ho/observability that referenced this pull request Jan 13, 2023
* remove front end workflow and code

Signed-off-by: Derek Ho <[email protected]>

* move folders up one level

Signed-off-by: Derek Ho <[email protected]>

* fix workflow file

Signed-off-by: Derek Ho <[email protected]>

* final workflow fix

Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit e7dea87)
Signed-off-by: Derek Ho <[email protected]>
derek-ho added a commit that referenced this pull request Jan 18, 2023
* remove front end workflow and code (#1362)

* remove front end workflow and code

Signed-off-by: Derek Ho <[email protected]>

* move folders up one level

Signed-off-by: Derek Ho <[email protected]>

* fix workflow file

Signed-off-by: Derek Ho <[email protected]>

* final workflow fix

Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit e7dea87)
Signed-off-by: Derek Ho <[email protected]>

* delete front end workflow file

Signed-off-by: Derek Ho <[email protected]>

* ichange bwc version

Signed-off-by: Derek Ho <[email protected]>

* fix build.gradel

Signed-off-by: Derek Ho <[email protected]>

* try to replace all references

Signed-off-by: Derek Ho <[email protected]>

* fix job scheduler version

Signed-off-by: Derek Ho <[email protected]>

* add job scheduler into bwc tests

Signed-off-by: Derek Ho <[email protected]>

* change version to 2.4.0

Signed-off-by: Derek Ho <[email protected]>

* run all jobs

Signed-off-by: Derek Ho <[email protected]>

* add back bwc

Signed-off-by: Derek Ho <[email protected]>

* add job scheduler back

Signed-off-by: Derek Ho <[email protected]>

* fix

Signed-off-by: Derek Ho <[email protected]>

* fix the file

Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants