[FEAT] Enable limited trace analytics feature on raw jaeger indices #1336

derek-ho · 2022-12-07T20:45:28Z

Description

Issues Resolved

opensearch-project/dashboards-observability#83

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>

…o HEAD Signed-off-by: Derek Ho <[email protected]>

…ges to work with this framework Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>

…e on out Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>

codecov-commenter · 2022-12-16T16:02:30Z

Codecov Report

Merging #1336 (398f6f5) into 2.x (042846e) will increase coverage by 28.21%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.x    #1336       +/-   ##
=============================================
+ Coverage     41.89%   70.10%   +28.21%     
  Complexity      315      315               
=============================================
  Files           302       46      -256     
  Lines         17849     2482    -15367     
  Branches       4332      253     -4079     
=============================================
- Hits           7477     1740     -5737     
+ Misses        10199      600     -9599     
+ Partials        173      142       -31

Flag	Coverage Δ
dashboards-observability	`?`
opensearch-observability	`70.10% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-observability/common/constants/trace_analytics.ts
...cs/components/config_components/service_config.tsx
...tics/components/config_components/trace_config.tsx
...mponents/flyout_components/trace_detail_render.tsx
.../explorer/events_views/trace_block/trace_block.tsx
...ytics/components/common/filters/filter_helpers.tsx
...ce_analytics/components/common/filters/filters.tsx
...e_analytics/components/common/helper_functions.tsx
...alytics/components/common/plots/error_rate_plt.tsx
...alytics/components/common/plots/throughput_plt.tsx
... and 246 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Derek Ho <[email protected]>

…aeger Signed-off-by: Derek Ho <[email protected]>

...oards-observability/public/components/trace_analytics/components/common/helper_functions.tsx

dashboards-observability/common/constants/trace_analytics.ts

...oards-observability/public/components/trace_analytics/components/common/helper_functions.tsx

...s-observability/public/components/trace_analytics/components/common/plots/error_rate_plt.tsx

joshuali925 · 2023-01-03T21:42:32Z

...s-observability/public/components/trace_analytics/components/dashboard/dashboard_content.tsx

+                    <ErrorRatePlt
+                      items={errorRatePltItems}
+                      setStartTime={setStartTime}
+                      setEndTime={setEndTime}


missing the new attributes? or some are not required?

dashboards-observability/public/components/trace_analytics/components/dashboard/mode_picker.tsx

joshuali925 · 2023-01-03T21:51:08Z

dashboards-observability/public/components/trace_analytics/home.tsx

+  //   } else {
+  //     setMode('none');
+  //   }
+  // }, [jaegerIndicesExist, dataPrepperIndicesExist]);


remove if not needed

joshuali925 · 2023-01-03T21:54:50Z

dashboards-observability/public/components/trace_analytics/components/dashboard/mode_picker.tsx

+import React, { useEffect, useState } from "react";
+import { TraceAnalyticsMode } from "../../home";
+
+export type mode = {


where is this used?

joshuali925 · 2023-01-03T21:57:06Z

dashboards-observability/public/components/trace_analytics/components/dashboard/mode_picker.tsx

+                    setMode(choice.key);
+                    setSelected(choice.key);
+                    setPopoverIsOpen(false);
+                    sessionStorage.setItem('TraceAnalyticsMode', choice.key);


should mode be persisted over different sessions? or it's common for users to use both data prepper and jaeger indices

Signed-off-by: Derek Ho <[email protected]>

derek-ho added 30 commits November 17, 2022 17:29

get traces page working with queries

cdaace3

Signed-off-by: Derek Ho <[email protected]>

get trace individual page partially working

9a6dd99

Signed-off-by: Derek Ho <[email protected]>

get service page working initially

2d01f9e

Signed-off-by: Derek Ho <[email protected]>

get services page mainly working

b71bf9e

Signed-off-by: Derek Ho <[email protected]>

get most things working except for dashboards

74f1884

Signed-off-by: Derek Ho <[email protected]>

something is broken

5a027e8

Signed-off-by: Derek Ho <[email protected]>

get time working on traces query

a62374e

Signed-off-by: Derek Ho <[email protected]>

last commit for today

e89e17b

Signed-off-by: Derek Ho <[email protected]>

done for today for real

03f33f9

Signed-off-by: Derek Ho <[email protected]>

fix date filter

a2abf61

Signed-off-by: Derek Ho <[email protected]>

trying to fix span table

b94d6d1

Signed-off-by: Derek Ho <[email protected]>

save work

97da4e6

Signed-off-by: Derek Ho <[email protected]>

mostly fix trace page

a40e873

Signed-off-by: Derek Ho <[email protected]>

services working and traces working

f75269e

Signed-off-by: Derek Ho <[email protected]>

fix some more stuff

551401e

Signed-off-by: Derek Ho <[email protected]>

fix error shown on span detail chart

7e7e1fe

Signed-off-by: Derek Ho <[email protected]>

fix

2659e8b

Signed-off-by: Derek Ho <[email protected]>

make general

2de9ca7

Signed-off-by: Derek Ho <[email protected]>

Merge branch '2.x' of github.com:opensearch-project/observability int…

16da197

…o HEAD Signed-off-by: Derek Ho <[email protected]>

make everything more general and get traces and services top level pa…

25a5bf1

…ges to work with this framework Signed-off-by: Derek Ho <[email protected]>

get subpages working and get rid of servicemap when in jaeger mode

3e2e580

Signed-off-by: Derek Ho <[email protected]>

make most work on both

a762cc9

Signed-off-by: Derek Ho <[email protected]>

pushing work

bc54a21

Signed-off-by: Derek Ho <[email protected]>

fix service map for data prepper

20d1f51

Signed-off-by: Derek Ho <[email protected]>

get more things to work

c25f9e3

Signed-off-by: Derek Ho <[email protected]>

push work

e2eef1d

Signed-off-by: Derek Ho <[email protected]>

get almost everything working

3470115

Signed-off-by: Derek Ho <[email protected]>

everything on parity - new features and UX fixes only needed from her…

a0484d9

…e on out Signed-off-by: Derek Ho <[email protected]>

fix service flyout pannel

8cc7811

Signed-off-by: Derek Ho <[email protected]>

fix app analytics

be7e915

Signed-off-by: Derek Ho <[email protected]>

derek-ho added 3 commits December 12, 2022 12:45

default to data prepper for app analytics

3c10379

Signed-off-by: Derek Ho <[email protected]>

try to fix failing tests

a5c1724

Signed-off-by: Derek Ho <[email protected]>

try to fix some more syntax and test issues

018080f

Signed-off-by: Derek Ho <[email protected]>

derek-ho added 15 commits December 16, 2022 11:11

fix a few more things

58acf11

Signed-off-by: Derek Ho <[email protected]>

replace with union

eaf2a51

Signed-off-by: Derek Ho <[email protected]>

fix a few more tests

33ebf81

Signed-off-by: Derek Ho <[email protected]>

all test pass!

dd3039c

Signed-off-by: Derek Ho <[email protected]>

try to get mode picker

7a406b8

Signed-off-by: Derek Ho <[email protected]>

get it hooked up - still need to iron out a few things

dbd8958

Signed-off-by: Derek Ho <[email protected]>

get it working

d048eda

Signed-off-by: Derek Ho <[email protected]>

fix a few things

7070a37

Signed-off-by: Derek Ho <[email protected]>

some more work to get plots in

3b9cbc6

Signed-off-by: Derek Ho <[email protected]>

fix filters

21098ad

Signed-off-by: Derek Ho <[email protected]>

add code to get to demo point

e7cc6fa

Signed-off-by: Derek Ho <[email protected]>

implement toggle on dashboard

3eae13f

Signed-off-by: Derek Ho <[email protected]>

remove package lock

0168e1f

Signed-off-by: Derek Ho <[email protected]>

fix everything and get ui working well

f8f6bee

Signed-off-by: Derek Ho <[email protected]>

Merge branch '2.x' of github.com:derek-ho/observability into enable-j…

fe362aa

…aeger Signed-off-by: Derek Ho <[email protected]>

joshuali925 reviewed Jan 3, 2023

View reviewed changes

derek-ho added 6 commits January 4, 2023 13:38

add json files

d7a18f9

Signed-off-by: Derek Ho <[email protected]>

update file

89db6ea

Signed-off-by: Derek Ho <[email protected]>

fix mapping files

15ee222

Signed-off-by: Derek Ho <[email protected]>

fix file

8ef057e

Signed-off-by: Derek Ho <[email protected]>

remote dynamic templates

398f6f5

Signed-off-by: Derek Ho <[email protected]>

fix

9909947

Signed-off-by: Derek Ho <[email protected]>

derek-ho closed this by deleting the head repository Jan 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] Enable limited trace analytics feature on raw jaeger indices #1336

[FEAT] Enable limited trace analytics feature on raw jaeger indices #1336

derek-ho commented Dec 7, 2022 •

edited

Loading

codecov-commenter commented Dec 16, 2022 •

edited

Loading

joshuali925 Jan 3, 2023

joshuali925 Jan 3, 2023

joshuali925 Jan 3, 2023

joshuali925 Jan 3, 2023

[FEAT] Enable limited trace analytics feature on raw jaeger indices #1336

[FEAT] Enable limited trace analytics feature on raw jaeger indices #1336

Conversation

derek-ho commented Dec 7, 2022 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Dec 16, 2022 • edited Loading

Codecov Report

joshuali925 Jan 3, 2023

Choose a reason for hiding this comment

joshuali925 Jan 3, 2023

Choose a reason for hiding this comment

joshuali925 Jan 3, 2023

Choose a reason for hiding this comment

joshuali925 Jan 3, 2023

Choose a reason for hiding this comment

derek-ho commented Dec 7, 2022 •

edited

Loading

codecov-commenter commented Dec 16, 2022 •

edited

Loading