Add more metrics to frontend #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1326 +/- ##
=========================================
Coverage 41.82% 41.82%
Complexity 315 315
=========================================
Files 302 302
Lines 17840 17840
Branches 4285 4285
=========================================
Hits 7462 7462
Misses 10205 10205
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Joshua Li <[email protected]>
joshuali925
force-pushed
the
frontend-metrics
branch
from
6f0d30a to
1312314
Compare
joshuali925
commented
Dec 5, 2022
| @@ -64,8 +64,10 @@ export function addRequestToMetric( | |||
| const timeKey = getKey(Date.now()); | |||
| const rollingCounter = time2CountWin.get(timeKey) || _.cloneDeep(DEFAULT_ROLLING_COUNTER); | |||
|
|
|||
| // @ts-ignore not sure why 'request' can't be indexed | |||
| rollingCounter[component][request][counter]!++; | |||
There was a problem hiding this comment.
The error is Type 'RequestType<T>' cannot be used to index type 'CounterType[T]'., let me know if anyone knows how I should change it and i can remove the @ts-ignore
mengweieric
approved these changes
Dec 6, 2022
ps48
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more metrics to frontend, followup PR for #1306
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.