Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics for backend plugin #1323

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Dec 2, 2022

Signed-off-by: Joshua Li [email protected]

Description

Add more metrics to backend, follow up PR for #1306

{
  "saved_visualization": {
    "create": {
      "count": 0,
      "total": 0
    },
    "update": {
      "total": 0,
      "count": 0
    }
  },
  "permission_user_error": 0,
  "observability": {
    "update": {
      "total": 0,
      "user_error": 0,
      "count": 0,
      "system_error": 0
    },
    "delete": {
      "user_error": 0,
      "total": 0,
      "system_error": 0,
      "count": 0
    },
    "get": {
      "user_error": 0,
      "system_error": 0,
      "total": 0,
      "count": 0
    },
    "create": {
      "user_error": 0,
      "system_error": 0,
      "total": 0,
      "count": 0
    }
  },
  "request_total": 0,
  "saved_query": {
    "create": {
      "total": 0,
      "count": 0
    },
    "update": {
      "total": 0,
      "count": 0
    }
  },
  "timestamp": {
    "create": {
      "total": 0,
      "count": 0
    },
    "update": {
      "count": 0,
      "total": 0
    }
  },
  "application": {
    "update": {
      "count": 0,
      "total": 0
    },
    "create": {
      "total": 0,
      "count": 0
    }
  },
  "exception": {
    "illegal_state": 0,
    "illegal_argument": 0,
    "opensearch_status": 0,
    "io": 0,
    "version_conflict_engine": 0,
    "opensearch_security": 0,
    "invalid_index_name": 0,
    "index_not_found": 0,
    "internal_server_error": 0
  },
  "notebook": {
    "create": {
      "count": 0,
      "total": 0
    },
    "update": {
      "total": 0,
      "count": 0
    }
  },
  "operational_panel": {
    "update": {
      "total": 0,
      "count": 0
    },
    "create": {
      "total": 0,
      "count": 0
    }
  },
  "failed_request_count_system_error": 0,
  "security_permission_error": 0,
  "success_count": 0,
  "request_count": 0,
  "failed_request_count_user_error": 0
}

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 marked this pull request as ready for review December 5, 2022 18:50
@joshuali925 joshuali925 requested a review from a team as a code owner December 5, 2022 18:50
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #1323 (fe06f8c) into 2.x (17b8771) will increase coverage by 0.23%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##                2.x    #1323      +/-   ##
============================================
+ Coverage     41.82%   42.06%   +0.23%     
  Complexity      315      315              
============================================
  Files           302      302              
  Lines         17840    17917      +77     
  Branches       4285     4286       +1     
============================================
+ Hits           7462     7536      +74     
- Misses        10205    10207       +2     
- Partials        173      174       +1     
Flag Coverage Δ
dashboards-observability 37.25% <ø> (ø)
opensearch-observability 70.88% <92.30%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ervability/action/GetObservabilityObjectRequest.kt 93.25% <0.00%> (-1.06%) ⬇️
...rg/opensearch/observability/model/SearchResults.kt 93.33% <0.00%> (-2.13%) ⬇️
...ability/action/UpdateObservabilityObjectRequest.kt 91.37% <75.00%> (+0.81%) ⬆️
...ability/action/CreateObservabilityObjectRequest.kt 96.22% <85.71%> (+0.39%) ⬆️
...bility/action/CreateObservabilityObjectResponse.kt 100.00% <100.00%> (ø)
...ability/action/DeleteObservabilityObjectRequest.kt 93.93% <100.00%> (+0.39%) ⬆️
...bility/action/DeleteObservabilityObjectResponse.kt 91.17% <100.00%> (+0.55%) ⬆️
...bility/action/UpdateObservabilityObjectResponse.kt 100.00% <100.00%> (ø)
...in/org/opensearch/observability/metrics/Metrics.kt 93.42% <100.00%> (+11.27%) ⬆️
...ervability/resthandler/ObservabilityRestHandler.kt 86.59% <100.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mengweieric
mengweieric previously approved these changes Dec 6, 2022
@kavithacm kavithacm merged commit 3720885 into opensearch-project:2.x Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Add more metrics for backend plugin

Signed-off-by: Joshua Li <[email protected]>

* Fix tests

Signed-off-by: Joshua Li <[email protected]>

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 3720885)
joshuali925 added a commit that referenced this pull request Jan 10, 2023
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 3720885)

Co-authored-by: Joshua Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants