Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing search feature #1286

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Conversation

sejli
Copy link
Member

@sejli sejli commented Nov 22, 2022

Signed-off-by: Sean Li [email protected]

Description

  • Added dynamic searching for metric names in Metric Analytics
  • Updated some UI elements

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sejli sejli requested a review from a team as a code owner November 22, 2022 23:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #1286 (0f2072f) into 2.x (fe97804) will increase coverage by 28.56%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.x    #1286       +/-   ##
=============================================
+ Coverage     41.70%   70.27%   +28.56%     
  Complexity      292      292               
=============================================
  Files           296       42      -254     
  Lines         17747     2395    -15352     
  Branches       4277      248     -4029     
=============================================
- Hits           7401     1683     -5718     
+ Misses        10174      571     -9603     
+ Partials        172      141       -31     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/metrics/redux/slices/metrics_slice.ts
...y/public/components/metrics/sidebar/search_bar.tsx
...lity/public/components/metrics/sidebar/sidebar.tsx
...ty/public/components/metrics/top_menu/top_menu.tsx
...blic/components/common/helpers/ppl_docs/groups.tsx
...vent_analytics/redux/slices/visualization_slice.ts
...vability/common/query_manager/ppl_query_manager.ts
...nts/visualizations/charts/shared/shared_configs.ts
...onents/event_analytics/hooks/use_fetch_patterns.ts
...s/trace_analytics/components/services/services.tsx
... and 244 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ps48
ps48 previously approved these changes Nov 22, 2022
@mengweieric
Copy link
Collaborator

Please address the failing tests.

@ps48
Copy link
Member

ps48 commented Nov 22, 2022

@sejli Can you please update unit test snapshots here?

Signed-off-by: Sean Li <[email protected]>
@ps48 ps48 merged commit 0ee5e1d into opensearch-project:2.x Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants