Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fixed app crash and reverted chart types #1197

Closed

Conversation

Koustubh5585
Copy link
Contributor

Signed-off-by: Koustubh Karmalkar [email protected]

Description

  • Fixed app crash when series removed, updated the chart and again tried to add new series
  • Reverted the vis_chart_types
  • Fixed On click of refresh twice the query resets to original query despite the user has made changes in the query

Issues Resolved

#1141

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Koustubh5585 Koustubh5585 requested a review from a team as a code owner October 27, 2022 14:27
Signed-off-by: Koustubh Karmalkar <[email protected]>
Signed-off-by: Koustubh Karmalkar <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1197 (85582d7) into main (f9ee36d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   47.69%   47.69%           
=======================================
  Files         239      239           
  Lines        7217     7217           
  Branches     2004     2004           
=======================================
  Hits         3442     3442           
  Misses       3745     3745           
  Partials       30       30           
Flag Coverage Δ
dashboards-observability 47.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboards-observability/common/constants/shared.ts 100.00% <ø> (ø)
...ponents/visualizations/charts/helpers/viz_types.ts 30.43% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants