Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fixed Consolidated UI issues #1173

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

Amit-Nawale
Copy link
Contributor

@Amit-Nawale Amit-Nawale commented Oct 21, 2022

Description
  1. Back option in series and dimensions have an arrow head in place of hand pointer.

  2. Single select dropdowns in Unit Dropdown & Timestamp looks like multiselect dropdowns.

  3. The resize button on chart visualization panel overlaps with the border.

    Issues Resolved

  • Back option in series and dimensions now have an arrow head
  • Unit Dropdown & Timestamp have single select dropdowns
  • Resize button on either side of the panel is not overlapping now.

#1117

Check List

  • Commits are signed per the DCO using --signoff

@Amit-Nawale Amit-Nawale requested a review from a team as a code owner October 21, 2022 10:18
@Amit-Nawale Amit-Nawale changed the title [BUG]: Fixed Consolidated UI issues #1117 [BUG]: Fixed Consolidated UI issues Oct 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #1173 (7dedd61) into main (7930865) will increase coverage by 18.15%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1173       +/-   ##
=============================================
+ Coverage     53.72%   71.87%   +18.15%     
  Complexity      291      291               
=============================================
  Files           279       42      -237     
  Lines          9486     2311     -7175     
  Branches       2242      240     -2002     
=============================================
- Hits           5096     1661     -3435     
+ Misses         4220      509     -3711     
+ Partials        170      141       -29     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../visualizations/charts/logs_view/logs_view_type.ts
...isualizations/charts/financial/gauge/gauge_type.ts
...ks/components/paragraph_components/para_output.tsx
...y/public/components/common/search/autocomplete.tsx
...omponents/common/helpers/ppl_docs/commands/rare.ts
...e_analytics/components/common/helper_functions.tsx
.../components/visualizations/visualization_chart.tsx
...s/notebooks/components/helpers/zeppelin_parser.tsx
...ger/antlr/adaptors/case_insensitive_char_stream.ts
...ponents/visualizations/charts/maps/treemap_type.ts
... and 227 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anirudha
anirudha previously approved these changes Oct 21, 2022
@Amit-Nawale Amit-Nawale requested a review from anirudha November 2, 2022 05:20
@mengweieric mengweieric merged commit a0b02a5 into opensearch-project:main Nov 2, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
* Consolidated UI issues are fixed

Signed-off-by: Amit-Nawale <[email protected]>

* Consolidated UI issues are fixed

Signed-off-by: Amit-Nawale <[email protected]>

* Consolidated UI issues are fixed

Signed-off-by: Amit-Nawale <[email protected]>

* Implemented commented changes

Signed-off-by: Amit-Nawale <[email protected]>

Signed-off-by: Amit-Nawale <[email protected]>
(cherry picked from commit a0b02a5)
derek-ho pushed a commit that referenced this pull request Dec 22, 2022
* Consolidated UI issues are fixed

Signed-off-by: Amit-Nawale <[email protected]>

* Consolidated UI issues are fixed

Signed-off-by: Amit-Nawale <[email protected]>

* Consolidated UI issues are fixed

Signed-off-by: Amit-Nawale <[email protected]>

* Implemented commented changes

Signed-off-by: Amit-Nawale <[email protected]>

Signed-off-by: Amit-Nawale <[email protected]>
(cherry picked from commit 43c2eaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants