[BUG]: Visualizations not appearing in Operational Panels fixed #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengweieric
reviewed
Oct 20, 2022
| return <></>; | ||
| } | ||
| return ( | ||
| <Visualization | ||
| visualizations={getVizContainerProps({ | ||
| vizId: type, | ||
| rawVizData: data, | ||
| query: {}, | ||
| query: { rawQuery: metaData.query }, |
There was a problem hiding this comment.
Do we need to handle a corner case when metaData does not contain query field?
There was a problem hiding this comment.
it has been handled when metaData is empty object, it wont render Visualization, and also we can not save the data without query. I believe it is not required!.
eugenesk24
reviewed
Oct 20, 2022
| @@ -289,15 +289,15 @@ export const isPPLFilterValid = ( | |||
|
|
|||
| // Renders visualization in the vizualization container component | |||
| export const displayVisualization = (metaData: any, data: any, type: string) => { | |||
| if (metaData === undefined || metaData === {}) { | |||
| if (metaData === undefined || Object.keys(metaData).length === 0) { | |||
There was a problem hiding this comment.
isEmpty(metaData) might look cleaner
SivaprasadAluri
force-pushed
the
bug/operationalPanel_Issue_907
branch
from
7fea280 to
51e5067
Compare
Codecov Report
@@ Coverage Diff @@
## main #1170 +/- ##
============================================
+ Coverage 53.70% 55.81% +2.10%
Complexity 291 291
============================================
Files 279 279
Lines 9490 9490
Branches 2244 2244
============================================
+ Hits 5097 5297 +200
+ Misses 4223 4021 -202
- Partials 170 172 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuali925
previously approved these changes
Oct 21, 2022
anirudha
previously approved these changes
Oct 21, 2022
Signed-off-by: SivaprasadAluri <[email protected]>
Signed-off-by: SivaprasadAluri <[email protected]>
SivaprasadAluri
dismissed stale reviews from anirudha and joshuali925
via
1c37c5f
SivaprasadAluri
force-pushed
the
bug/operationalPanel_Issue_907
branch
from
51e5067 to
1c37c5f
Compare
Signed-off-by: SivaprasadAluri <[email protected]>
SivaprasadAluri
requested review from
pjfitzgibbons,
mengweieric,
anirudha,
joshuali925 and
eugenesk24
and removed request for
ps48,
eugenesk24,
pjfitzgibbons,
mengweieric,
anirudha and
joshuali925
SivaprasadAluri
requested review from
pjfitzgibbons and
anirudha
and removed request for
mengweieric and
pjfitzgibbons
pjfitzgibbons
approved these changes
Oct 24, 2022
eugenesk24
approved these changes
Oct 24, 2022
mengweieric
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SivaprasadAluri [email protected]
Description
Fixed the Saved visualizations will appear in operational panel after creating the panel
Issues Resolved
[BUG]: Visualizations not appearing in Operational Panels (#907)