-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] : Horizontal bar chart 2way sync #1094
Merged
mengweieric
merged 5 commits into
opensearch-project:main
from
DipraAich:feature/horizontal_bar_chart_2way_sync
Oct 11, 2022
Merged
[FEATURE] : Horizontal bar chart 2way sync #1094
mengweieric
merged 5 commits into
opensearch-project:main
from
DipraAich:feature/horizontal_bar_chart_2way_sync
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dipra Aich <[email protected]>
Signed-off-by: Dipra Aich <[email protected]>
Signed-off-by: Dipra Aich <[email protected]>
Signed-off-by: Dipra Aich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1094 +/- ##
=============================================
+ Coverage 53.53% 71.87% +18.33%
Complexity 291 291
=============================================
Files 280 42 -238
Lines 9356 2311 -7045
Branches 2162 240 -1922
=============================================
- Hits 5009 1661 -3348
+ Misses 4177 509 -3668
+ Partials 170 141 -29
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mengweieric
reviewed
Oct 10, 2022
...ards-observability/public/components/visualizations/charts/__tests__/horizontal_bar.test.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/visualizations/charts/bar/bar.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/visualizations/charts/helpers/viz_types.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Dipra Aich <[email protected]>
ps48
approved these changes
Oct 11, 2022
mengweieric
approved these changes
Oct 11, 2022
kavithacm
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging horizontal and vertical bar chart visualizations
Implementing 2way sync in horizontal bar chart
Issues Resolved
#885
#1009
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.