Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] : Horizontal bar chart 2way sync #1094

Conversation

DipraAich
Copy link
Contributor

@DipraAich DipraAich commented Oct 7, 2022

Description

Merging horizontal and vertical bar chart visualizations
Implementing 2way sync in horizontal bar chart

Issues Resolved

#885
#1009

Check List

  • New functionality includes two-way sync for the Horizontal bar visualization.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DipraAich DipraAich requested a review from a team as a code owner October 7, 2022 08:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #1094 (a425794) into main (1c9c4f5) will increase coverage by 18.33%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1094       +/-   ##
=============================================
+ Coverage     53.53%   71.87%   +18.33%     
  Complexity      291      291               
=============================================
  Files           280       42      -238     
  Lines          9356     2311     -7045     
  Branches       2162      240     -1922     
=============================================
- Hits           5009     1661     -3348     
+ Misses         4177      509     -3668     
+ Partials        170      141       -29     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hboards-observability/common/constants/explorer.ts
...ashboards-observability/common/constants/shared.ts
...lorer/visualizations/config_panel/config_panel.tsx
..._panes/config_controls/config_bar_chart_styles.tsx
...izations/count_distribution/count_distribution.tsx
.../public/components/event_analytics/utils/utils.tsx
...race_analytics/components/common/plots/box_plt.tsx
...tics/components/common/plots/service_map_scale.tsx
...trace_analytics/requests/traces_request_handler.ts
...ublic/components/visualizations/charts/bar/bar.tsx
... and 227 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mengweieric mengweieric self-requested a review October 11, 2022 21:41
@mengweieric mengweieric merged commit 9ed7e5a into opensearch-project:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants