Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Kotlin version #1052

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Updating Kotlin version #1052

merged 7 commits into from
Sep 30, 2022

Conversation

sejli
Copy link
Member

@sejli sejli commented Sep 29, 2022

Signed-off-by: sejli [email protected]

Description

Updating Kotlin version for opensearch-observability to 1.6.0

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #1052 (fdd5e40) into 1.x (28e5b38) will increase coverage by 1.22%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                1.x    #1052      +/-   ##
============================================
+ Coverage     53.64%   54.87%   +1.22%     
- Complexity      271      283      +12     
============================================
  Files           244      244              
  Lines          7728     7747      +19     
  Branches       1559     1551       -8     
============================================
+ Hits           4146     4251     +105     
+ Misses         3391     3326      -65     
+ Partials        191      170      -21     
Flag Coverage Δ
dashboards-observability 46.51% <ø> (ø)
opensearch-observability 76.56% <100.00%> (+4.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pensearch/observability/settings/PluginSettings.kt 74.71% <100.00%> (+0.72%) ⬆️
...ensearch/observability/index/ObservabilityIndex.kt 57.48% <0.00%> (-5.62%) ⬇️
...search/observability/security/UserAccessManager.kt 7.24% <0.00%> (-2.76%) ⬇️
...ability/model/ObservabilityObjectDataProperties.kt 62.06% <0.00%> (-1.27%) ⬇️
.../org/opensearch/observability/model/Application.kt 4.68% <0.00%> (-0.08%) ⬇️
...tlin/org/opensearch/observability/model/RestTag.kt 100.00% <0.00%> (ø)
...rg/opensearch/observability/ObservabilityPlugin.kt 100.00% <0.00%> (ø)
...pensearch/observability/action/PluginBaseAction.kt 30.00% <0.00%> (ø)
...pensearch/observability/security/SecurityAccess.kt 0.00% <0.00%> (ø)
...rvability/action/GetObservabilityObjectResponse.kt 100.00% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Joshua Li <[email protected]>
kavithacm
kavithacm previously approved these changes Sep 30, 2022
Copy link
Collaborator

@kavithacm kavithacm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change

@sejli sejli merged commit e089c10 into opensearch-project:1.x Sep 30, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2022
* Updating Kotlin version to latest

Signed-off-by: sejli <[email protected]>

* Switch to 1.6.21 since latest fails tests

Signed-off-by: sejli <[email protected]>

* Switch to 1.6.0 because of issues, fixed some errors with build

Signed-off-by: sejli <[email protected]>

* Fix jacoco

Signed-off-by: Joshua Li <[email protected]>

* Minor changes

Signed-off-by: sejli <[email protected]>

* Fixing PathUtils import

Signed-off-by: sejli <[email protected]>

Signed-off-by: sejli <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit e089c10)
kavithacm pushed a commit that referenced this pull request Oct 3, 2022
* Updating Kotlin version to latest

Signed-off-by: sejli <[email protected]>

* Switch to 1.6.21 since latest fails tests

Signed-off-by: sejli <[email protected]>

* Switch to 1.6.0 because of issues, fixed some errors with build

Signed-off-by: sejli <[email protected]>

* Fix jacoco

Signed-off-by: Joshua Li <[email protected]>

* Minor changes

Signed-off-by: sejli <[email protected]>

* Fixing PathUtils import

Signed-off-by: sejli <[email protected]>

Signed-off-by: sejli <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit e089c10)

Co-authored-by: Sean Li <[email protected]>
@sejli sejli changed the title Updating Kotlin version to latest Updating Kotlin version Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants