Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crashes when user deletes Aggregation field #1047

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

Koustubh5585
Copy link
Contributor

@Koustubh5585 Koustubh5585 commented Sep 27, 2022

Description

Fixed crash when user deletes Aggregation field under Series section and when clicked on red 'X' button

Issues Resolved

#1024

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Koustubh5585 Koustubh5585 requested a review from a team as a code owner September 27, 2022 14:09
@codecov-commenter
Copy link

Codecov Report

Merging #1047 (05b70fc) into main (08a8d82) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main    #1047      +/-   ##
============================================
- Coverage     54.31%   54.29%   -0.02%     
  Complexity      291      291              
============================================
  Files           277      277              
  Lines          9106     9109       +3     
  Branches       2034     2040       +6     
============================================
  Hits           4946     4946              
- Misses         3990     3993       +3     
  Partials        170      170              
Flag Coverage Δ
dashboards-observability 48.32% <33.33%> (-0.03%) ⬇️
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lity/common/query_manager/ast/tree/aggragations.ts 0.00% <0.00%> (ø)
...ublic/components/visualizations/charts/bar/bar.tsx 12.00% <0.00%> (ø)
...ts/visualizations/charts/financial/gauge/gauge.tsx 29.16% <0.00%> (-0.42%) ⬇️
...ic/components/visualizations/charts/lines/line.tsx 31.63% <50.00%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mengweieric mengweieric merged commit dcf304c into opensearch-project:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants