table view with two way sync #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
============================================
+ Coverage 53.60% 53.61% +0.01%
Complexity 291 291
============================================
Files 280 280
Lines 9309 9335 +26
Branches 2135 2155 +20
============================================
+ Hits 4990 5005 +15
- Misses 4149 4160 +11
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ramneet-persistent
previously approved these changes
Sep 19, 2022
spattnaik
previously approved these changes
Sep 19, 2022
mengweieric
previously approved these changes
Sep 19, 2022
| @@ -46,6 +33,30 @@ export const DataTable = ({ visualizations, layout, config }: any) => { | |||
| metadata: { fields = [] }, | |||
| } = visualizations.data.rawVizData; | |||
|
|
|||
| const { dataConfig = {} } = visualizations?.data?.userConfigs; | |||
There was a problem hiding this comment.
Can we follow bar's viz data destruction code here to destruct data config so we don't have to make these multiple long lines of assignments?
| typeof dataConfig?.chartStyles?.columnWidth !== 'undefined' | ||
| ? dataConfig?.chartStyles?.columnWidth | ||
| : visualizations.vis.columnwidth; | ||
|
|
||
| useEffect(() => { | ||
| document.addEventListener('keydown', hideGridFullScreenHandler); | ||
| return () => { |
There was a problem hiding this comment.
from Line 70, seems like we can also use useMemo hook here, could we add this for column calculation?
|
Please address the comments and resolve the conflicts for this PR. |
ruchika-narang
dismissed stale reviews from mengweieric and spattnaik
via
03dc15e
ruchika-narang
force-pushed
the
feature/table-visualization
branch
from
4f15c16 to
03dc15e
Compare
Signed-off-by: abasatwar <[email protected]>
Signed-off-by: abasatwar <[email protected]>
Signed-off-by: abasatwar <[email protected]>
Signed-off-by: abasatwar <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
ruchika-narang
force-pushed
the
feature/table-visualization
branch
from
21ae219 to
813e24f
Compare
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
mengweieric
approved these changes
Sep 30, 2022
anirudha
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table view visualization with two way sync is implemented.
#916