replacing spi.utils isHostInDenyList with core.utils isHostInDenyList #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
zhongnansu,
sbcd90,
praveensameneni and
amsiglan
as code owners
eirsep
approved these changes
Apr 15, 2024
AWSHurneyt
approved these changes
Apr 15, 2024
amsiglan
approved these changes
Apr 15, 2024
|
Security and Linux Builds are known to be flaky, example merged PRs with same failing CIs: |
praveensameneni
approved these changes
Apr 15, 2024
sbcd90
approved these changes
Apr 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
…#904) Signed-off-by: Dennis Toepker <[email protected]> (cherry picked from commit fa4007c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90
pushed a commit
that referenced
this pull request
Apr 30, 2024
…#904) (#913) Signed-off-by: Dennis Toepker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing: on local cluster, added a sample hostname to the deny list, then created channel with custom webhook option to a URL that sends to the denied hostname and received following error:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.