Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hostname support for notifications deny list (#858) #860

Merged

Conversation

toepkerd
Copy link
Contributor

Signed-off-by: Dennis Toepker [email protected]
(cherry picked from commit 39bd3bf)

Description

Backport to 2.x of #858

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f72ce4a) 66.85% compared to head (4523a17) 66.85%.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #860   +/-   ##
=========================================
  Coverage     66.85%   66.85%           
  Complexity      263      263           
=========================================
  Files            39       39           
  Lines          1738     1738           
  Branches        165      165           
=========================================
  Hits           1162     1162           
  Misses          453      453           
  Partials        123      123           
Flag Coverage Δ
opensearch-notifications 66.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toepkerd toepkerd marked this pull request as ready for review February 15, 2024 21:09
@amsiglan amsiglan merged commit 6a1618b into opensearch-project:2.x Feb 15, 2024
18 checks passed
@toepkerd toepkerd deleted the backport/backport-858-to-2.x branch March 14, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants