Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) #811

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) #811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions notifications/core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ dependencies {
implementation "com.amazonaws:aws-java-sdk-ses:${aws_version}"
implementation "com.sun.mail:javax.mail:1.6.2"
implementation "javax.activation:activation:1.1"
implementation "org.slf4j:slf4j-api:${versions.slf4j}" //Needed for httpclient5
implementation "org.apache.logging.log4j:log4j-slf4j-impl:${versions.log4j}"
testImplementation(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need backport 2.x? this is need for httpclient 5, 2.x branch still using 4.x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By my test, the error log of log4j really not seen in 2.x version, will close this backport PR, thanks!

'org.assertj:assertj-core:3.16.1',
'org.junit.jupiter:junit-jupiter-api:5.6.2',
Expand Down
Loading