Replace the TestMailServer to GreenMail server #801

rachana-dani · 2023-10-18T12:27:26Z

Description

[Describe what this change achieves]
Switched TestMailServer to GreenMail server

Issues Resolved

[List any issues this PR will resolve]
This is to stop using deprecated test smtp server

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hailong-am · 2023-10-19T02:06:17Z

@rachana-dani can you fix the DCO check? you need add -s flag with git commit command

notifications/core/src/test/kotlin/org/opensearch/notifications/core/smtp/SmtpEmailTests.kt

codecov · 2023-10-19T02:16:54Z

Codecov Report

Merging #801 (f7ac3f1) into main (eda85eb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #801   +/-   ##
=========================================
  Coverage     66.85%   66.85%           
  Complexity      263      263           
=========================================
  Files            39       39           
  Lines          1738     1738           
  Branches        165      165           
=========================================
  Hits           1162     1162           
  Misses          453      453           
  Partials        123      123

Flag	Coverage Δ
opensearch-notifications	`66.85% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

zhichao-aws

Is there a method to verify whether the GreenMail server recieve the notification?

Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]>

…x warning (opensearch-project#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]>

Signed-off-by: rdani <[email protected]>

Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]>

Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]>

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]>

Signed-off-by: rdani <[email protected]>

rachana-dani · 2023-10-19T04:25:20Z

Is there a method to verify whether the GreenMail server recieve the notification?

There is a method greenMail.receivedMessages. I am checking size of the returned object

rachana-dani · 2023-10-19T04:26:04Z

Is there a method to verify whether the GreenMail server recieve the notification?

There is a method greenMail.receivedMessages. I am checking size of the returned object

I have addressed all the comments. Please take a look.

rachana-dani · 2023-10-19T04:39:52Z

Is there a method to verify whether the GreenMail server recieve the notification?

There is a method greenMail.receivedMessages. I am checking size of the returned object

I have addressed all the comments. Please take a look.

@Hailong-am @zhichao-aws all the checks have passed.

notifications/core/build.gradle

rachana-dani · 2023-10-20T04:32:29Z

Can you please add a HackoberFest2023 label and help me merge this PR?

Signed-off-by: rdani <[email protected]>

Hailong-am

Looks good to me

notifications/core/build.gradle

Signed-off-by: rdani <[email protected]>

* Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> (cherry picked from commit 76ddcd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> (cherry picked from commit 76ddcd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add slf4j-api for greenmail Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]>

SuZhou-Joe · 2023-10-27T01:49:53Z

#789

* Add 2.11 release notes (opensearch-project#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (opensearch-project#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (opensearch-project#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (opensearch-project#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (opensearch-project#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]>

* Add 2.11 release notes (opensearch-project#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (opensearch-project#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (opensearch-project#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (opensearch-project#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (opensearch-project#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <[email protected]> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <[email protected]> * fix build in core Signed-off-by: zhichao-aws <[email protected]> * fix core-spi build Signed-off-by: zhichao-aws <[email protected]> * fix notifications main code Signed-off-by: zhichao-aws <[email protected]> * fix mappings, add IT Signed-off-by: zhichao-aws <[email protected]> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * put load mapping to initialize step Signed-off-by: zhichao-aws <[email protected]> * add schema_version field Signed-off-by: zhichao-aws <[email protected]> * add integ test Signed-off-by: zhichao-aws <[email protected]> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * add bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * resolve comments Signed-off-by: zhichao-aws <[email protected]> * add license header Signed-off-by: zhichao-aws <[email protected]> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <[email protected]> * modify integtest Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <[email protected]> * update release notes Signed-off-by: Hailong Cui <[email protected]> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <[email protected]> * fix wrong PR number Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <[email protected]> * revert app id Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <[email protected]> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Remove slackId from domainIds Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <[email protected]> * Add validation tests for Slack URL Signed-off-by: Aniruddh <[email protected]> * Format Signed-off-by: Aniruddh <[email protected]> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <[email protected]> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: yuye-aws <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: Rachana Dani <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Peter Zhu <[email protected]>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <[email protected]> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <[email protected]> * fix build in core Signed-off-by: zhichao-aws <[email protected]> * fix core-spi build Signed-off-by: zhichao-aws <[email protected]> * fix notifications main code Signed-off-by: zhichao-aws <[email protected]> * fix mappings, add IT Signed-off-by: zhichao-aws <[email protected]> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * put load mapping to initialize step Signed-off-by: zhichao-aws <[email protected]> * add schema_version field Signed-off-by: zhichao-aws <[email protected]> * add integ test Signed-off-by: zhichao-aws <[email protected]> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * add bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * resolve comments Signed-off-by: zhichao-aws <[email protected]> * add license header Signed-off-by: zhichao-aws <[email protected]> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <[email protected]> * modify integtest Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <[email protected]> * update release notes Signed-off-by: Hailong Cui <[email protected]> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <[email protected]> * fix wrong PR number Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <[email protected]> * revert app id Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <[email protected]> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Remove slackId from domainIds Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <[email protected]> * Add validation tests for Slack URL Signed-off-by: Aniruddh <[email protected]> * Format Signed-off-by: Aniruddh <[email protected]> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <[email protected]> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: yuye-aws <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: Rachana Dani <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Peter Zhu <[email protected]> (cherry picked from commit 87109a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo * Added feature support for microsoft teams webhook ,removed valid webhooks * Added feature support for Microsoft teams webhook * Refactored feature support for ms teams and added unit and integTest * fix build in core * fix core-spi build * fix notifications main code * fix mappings, add IT * add auto upgrade mapping logic * put load mapping to initialize step * add schema_version field * add integ test * adjust with auto upgrade mapping logic * add bwc * modify bwc * modify bwc * resolve comments * add license header * fix microsoft teams sample url in IT to adapt url validation --------- * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams * modify integtest --------- * onboard system and hidden index (#742) * Updates demo certs used in integ tests (#756) * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes * update release notes * Update opensearch-notifications.release-notes-2.10.0.0.md * fix wrong PR number --------- * bump bwc version to 2.11 (#763) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Impove security plugin enabling check (#792) * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow * revert app id --------- * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Replace the TestMailServer to GreenMail server * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * Add assertion for retrieval of notification * Update to stable version * Update to stable version * Update to suggested version --------- * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions * Add more --------- * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. * Undid 80fc198 Removed slf4j-jdk14.jar from classpath * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath --------- * Added Slack webhook URL validation regex * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replace path of mock Slack URL with `sample_slack_url` * Remove slackId from domainIds * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Add tests for wrong Slack URLs * Add validation tests for Slack URL * Format * GovSlack apps can use the slack-gov.com domain * Add validation for gov-slack.com domain --------- (cherry picked from commit 87109a0) Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: yuye-aws <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: Rachana Dani <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Peter Zhu <[email protected]>

rachana-dani requested review from xluo-aws, gaobinlong, Hailong-am, SuZhou-Joe, zhichao-aws, yuye-aws and zhongnansu as code owners October 18, 2023 12:27

rachana-dani mentioned this pull request Oct 18, 2023

Replace TestMailServer with GreenMail for email destination unit test #789

Closed

Hailong-am reviewed Oct 19, 2023

View reviewed changes

notifications/core/src/test/kotlin/org/opensearch/notifications/core/smtp/SmtpEmailTests.kt Show resolved Hide resolved

zhichao-aws reviewed Oct 19, 2023

View reviewed changes

yuye-aws and others added 6 commits October 19, 2023 09:30

Add 2.11 release notes (opensearch-project#774)

b0b810d

Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]>

Replace the TestMailServer to GreenMail server

eaa011b

Signed-off-by: rdani <[email protected]>

bump bwc version to 2.12 (opensearch-project#793)

4c92c7f

Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]>

Update dependency org.json:json to v20231013 (opensearch-project#795)

1fe5dee

Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]>

Re-enable detekt (opensearch-project#796)

4cf6ace

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]>

rachana-dani force-pushed the main branch from 2c72246 to 4cf6ace Compare October 19, 2023 04:00

rachana-dani and others added 2 commits October 19, 2023 09:31

Merge branch 'main' into main

c85d0d4

Add assertion for retrieval of notification

69f0070

Signed-off-by: rdani <[email protected]>

Hailong-am reviewed Oct 19, 2023

View reviewed changes

notifications/core/build.gradle Outdated Show resolved Hide resolved

Merge branch 'main' into main

69c0d41

Update to stable version

14bdf7e

Signed-off-by: rdani <[email protected]>

Hailong-am added the HackoberFest2023 label Oct 20, 2023

Update to stable version

76fbf2e

Signed-off-by: rdani <[email protected]>

Hailong-am previously approved these changes Oct 23, 2023

View reviewed changes

Hailong-am reviewed Oct 23, 2023

View reviewed changes

notifications/core/build.gradle Outdated Show resolved Hide resolved

Update to suggested version

f7ac3f1

Signed-off-by: rdani <[email protected]>

rachana-dani dismissed Hailong-am’s stale review via f7ac3f1 October 23, 2023 02:23

Hailong-am added the backport 2.x label Oct 23, 2023

Hailong-am approved these changes Oct 23, 2023

View reviewed changes

zhichao-aws approved these changes Oct 23, 2023

View reviewed changes

zhichao-aws merged commit 76ddcd4 into opensearch-project:main Oct 23, 2023
15 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 23, 2023

[Backport 2.x] Replace the TestMailServer to GreenMail server #807

Merged

Hailong-am added the OSCI label Nov 22, 2023

zhichao-aws added the v2.12.0 Issues targeting release v2.12.0 label Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace the TestMailServer to GreenMail server #801

Replace the TestMailServer to GreenMail server #801

rachana-dani commented Oct 18, 2023 •

edited by Hailong-am

Loading

Hailong-am commented Oct 19, 2023

codecov bot commented Oct 19, 2023 •

edited

Loading

zhichao-aws left a comment

rachana-dani commented Oct 19, 2023

rachana-dani commented Oct 19, 2023

rachana-dani commented Oct 19, 2023

rachana-dani commented Oct 20, 2023

Hailong-am left a comment

SuZhou-Joe commented Oct 27, 2023

Replace the TestMailServer to GreenMail server #801

Replace the TestMailServer to GreenMail server #801

Conversation

rachana-dani commented Oct 18, 2023 • edited by Hailong-am Loading

Description

Issues Resolved

Check List

Hailong-am commented Oct 19, 2023

codecov bot commented Oct 19, 2023 • edited Loading

Codecov Report

zhichao-aws left a comment

Choose a reason for hiding this comment

rachana-dani commented Oct 19, 2023

rachana-dani commented Oct 19, 2023

rachana-dani commented Oct 19, 2023

rachana-dani commented Oct 20, 2023

Hailong-am left a comment

Choose a reason for hiding this comment

SuZhou-Joe commented Oct 27, 2023

rachana-dani commented Oct 18, 2023 •

edited by Hailong-am

Loading

codecov bot commented Oct 19, 2023 •

edited

Loading