Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added org.apache.logging.log4j:log4j-slf4j-impl to classpath #791

Merged
merged 4 commits into from
Nov 2, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions notifications/notifications/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ dependencies {
exclude group: 'org.jetbrains', module: 'annotations' // resolve jarhell
} // ${kotlin_version} does not work for coroutines
implementation "${group}:common-utils:${common_utils_version}"
implementation "org.slf4j:slf4j-jdk14:1.7.32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add dependency on slf4j-api instead? and use versions.slf4j instead of hard code to 1.7.32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, instead of having implementation "org.slf4j:slf4j-jdk14:1.7.32", would it be better to have implementation "org.slf4j:slf4j-api:${versions.slf4j}"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please test if the warning is gone or not following the reproduce steps at #693

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By my test, this change doesn't work, the warning log still exists, please dive deep on it, thanks!

// TODO: change compile to implementation when the _local/stats API is supported
compileOnly "org.json:json:20230227"
compileOnly "com.github.wnameless.json:json-flattener:0.13.0"
Expand Down
Loading