Fix core XcontentFactory refactor #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
xluo-aws,
gaobinlong,
SuZhou-Joe,
zhichao-aws,
yuye-aws and
zhongnansu
as code owners
gaobinlong
approved these changes
Jul 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #732 +/- ##
=========================================
Coverage 66.19% 66.19%
Complexity 253 253
=========================================
Files 39 39
Lines 1698 1698
Branches 158 158
=========================================
Hits 1124 1124
Misses 456 456
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. |
xluo-aws
approved these changes
Jul 31, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-732-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 216dfcb95eff41ab04785980e89c0bd260b34042
# Push it to GitHub
git push --set-upstream origin backport/backport-732-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.xThen, create a pull request where the |
Hailong-am
added a commit
to Hailong-am/notifications
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 216dfcb)
Hailong-am
added a commit
that referenced
this pull request
Aug 7, 2023
* Fix core XcontentFactory refactor (#732) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 216dfcb) * Refactor XContentType to mediaType (#721) Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit d0a322c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downstream changes for XContentFactory refactor in core
Issues Resolved
opensearch-project/OpenSearch#8826
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.