-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings compile fix due to core package change #680
Merged
Hailong-am
merged 1 commit into
opensearch-project:main
from
petardz:strings-compile-fix
May 22, 2023
Merged
Strings compile fix due to core package change #680
Hailong-am
merged 1 commit into
opensearch-project:main
from
petardz:strings-compile-fix
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Dzepina <[email protected]>
petardz
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws and
zhongnansu
as code owners
May 19, 2023 22:58
Codecov Report
@@ Coverage Diff @@
## main #680 +/- ##
=========================================
Coverage 61.84% 61.84%
Complexity 114 114
=========================================
Files 73 73
Lines 2495 2495
Branches 266 266
=========================================
Hits 1543 1543
Misses 775 775
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xluo-aws
approved these changes
May 20, 2023
Hailong-am
approved these changes
May 22, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-680-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 36f1fcb6d7552729e7640adb82b4f65b87349132
# Push it to GitHub
git push --set-upstream origin backport/backport-680-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Hailong-am
pushed a commit
to Hailong-am/notifications
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 36f1fcb)
Hailong-am
pushed a commit
to Hailong-am/notifications
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 36f1fcb) Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
added a commit
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit 36f1fcb) Signed-off-by: Petar Dzepina <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: Petar Dzepina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed Strings class package due to change in core, to fix compile issues
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.