Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support microsoft teams webhooks #585 #612

Conversation

dankyalo599
Copy link
Contributor

@dankyalo599 dankyalo599 commented Feb 10, 2023

Description

Feature support microsoft teams webhooks #585

Issues Resolved

Posting to MSTeams channel through incoming webhook connector

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
abc

@dankyalo599 dankyalo599 requested a review from a team February 10, 2023 16:50
@dankyalo599 dankyalo599 force-pushed the _FEATURE_Support_Microsoft_Teams_webhooks_#585 branch from 4533dda to 077fd85 Compare February 10, 2023 16:54
@lezzago
Copy link
Member

lezzago commented Mar 16, 2023

Can the screenshot be a API call to create a teams channel? Then from there, call the test message on the teams channel to show it works fine. This would be a replacement for an integration test since we cannot have a real integration test on this as we dont want to expose webhook urls here.

@zhichao-aws
Copy link
Member

This PR is included in #638, can be closed

@zhichao-aws
Copy link
Member

stale PR, close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants