Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add index refresh after config creation and deletion in integration tests #592

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 62b8c36 from #590

…ests (#590)

* Add refresh to config creation in tests

Signed-off-by: Mohammad Qureshi <[email protected]>

* Remove duplicate createConfig utility methods for tests

Signed-off-by: Mohammad Qureshi <[email protected]>

* Replace delete config calls in tests with helper method with indices refresh

Signed-off-by: Mohammad Qureshi <[email protected]>

* Replace creating config from JSON string calls with helper method that refreshes indices

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update security test back to correct request with expected response assertion

Signed-off-by: Mohammad Qureshi <[email protected]>

Signed-off-by: Mohammad Qureshi <[email protected]>
(cherry picked from commit 62b8c36)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team January 6, 2023 21:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #592 (2aab0f1) into 2.x (41139ab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #592   +/-   ##
=========================================
  Coverage     70.74%   70.74%           
  Complexity      112      112           
=========================================
  Files           124      124           
  Lines          3951     3951           
  Branches        617      630   +13     
=========================================
  Hits           2795     2795           
  Misses          976      976           
  Partials        180      180           
Flag Coverage Δ
dashboards-notifications 86.40% <ø> (ø)
opensearch-notifications 61.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qreshi qreshi merged commit 72adccb into 2.x Jan 6, 2023
@github-actions github-actions bot deleted the backport/backport-590-to-2.x branch January 6, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants