Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Cypress test flakiness #574

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Reduce Cypress test flakiness #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c09bdb2
Add retries to first test in each Cypress suite to counter random tim…
qreshi Dec 6, 2022
05f379a
Update dashboard version in CI to 2.4.0 until branch is updated to ne…
qreshi Dec 6, 2022
f1f3b84
Move Cypress retry to global config
qreshi Dec 6, 2022
5d63d8c
Reduce Cypress retry count to 2
qreshi Dec 6, 2022
54e8c06
Remove MacOS from Dashboard test matrix for now
qreshi Dec 6, 2022
929b782
Remove include args for macos dashboard test
qreshi Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/dashboards-notifications-test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on: [pull_request, push]

env:
PLUGIN_NAME: notifications-dashboards
OPENSEARCH_DASHBOARDS_VERSION: '2.4'
OPENSEARCH_DASHBOARDS_VERSION: '2.4.0'
OPENSEARCH_VERSION: '2.4.0-SNAPSHOT'

jobs:
Expand All @@ -25,7 +25,8 @@ jobs:
# This setting says that all jobs should finish, even if one fails
fail-fast: false
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
# TODO: macos-latest was removed due to CI flakiness, we can revisit adding it back later
os: [ ubuntu-latest, windows-latest ]
include:
qreshi marked this conversation as resolved.
Show resolved Hide resolved
- os: windows-latest
working_directory: X:\
Expand All @@ -34,8 +35,9 @@ jobs:
- os: ubuntu-latest
jest_test_args: --coverage
cypress_cache_folder: ~/.cache/Cypress
- os: macos-latest
cypress_cache_folder: ~/Library/Caches/Cypress
# TODO: Add back when macos-latest is back in the test matrix
# - os: macos-latest
# cypress_cache_folder: ~/Library/Caches/Cypress


name: Test and Build Dashboards Notifications on ${{ matrix.os }}
Expand Down
4 changes: 4 additions & 0 deletions dashboards-notifications/cypress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"requestTimeout": 60000,
"responseTimeout": 60000,
"defaultCommandTimeout": 60000,
"retries": {
"runMode": 2,
"openMode": 2
},
"env": {
"opensearch": "localhost:9200",
"opensearchDashboards": "localhost:5601",
Expand Down