Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] add groupId to pluginzip publication #551

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7b15046 from #549

Signed-off-by: prudhvigodithi <[email protected]>

Signed-off-by: prudhvigodithi <[email protected]>
(cherry picked from commit 7b15046)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team October 13, 2022 18:05
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #551 (7b15046) into 2.x (47dfbc0) will not change coverage.
The diff coverage is 34.14%.

❗ Current head 7b15046 differs from pull request most recent head 74c48e5. Consider uploading reports for the commit 74c48e5 to get more accurate results

@@            Coverage Diff            @@
##                2.x     #551   +/-   ##
=========================================
  Coverage     70.74%   70.74%           
  Complexity      112      112           
=========================================
  Files           124      124           
  Lines          3951     3951           
  Branches        617      630   +13     
=========================================
  Hits           2795     2795           
  Misses          976      976           
  Partials        180      180           
Flag Coverage Δ
dashboards-notifications 86.40% <ø> (ø)
opensearch-notifications 61.36% <34.14%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...notifications/action/SendTestNotificationAction.kt 90.90% <ø> (ø)
...arch/notifications/send/SendMessageActionHelper.kt 42.39% <0.00%> (ø)
...rch/notifications/index/NotificationConfigIndex.kt 69.67% <16.66%> (ø)
...earch/notifications/spi/utils/ValidationHelpers.kt 43.33% <70.00%> (ø)
...notifications/core/client/DestinationHttpClient.kt 86.76% <100.00%> (ø)
...ications/resthandler/SendTestMessageRestHandler.kt 78.94% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn merged commit 89cd96c into 2.x Oct 13, 2022
@github-actions github-actions bot deleted the backport/backport-549-to-2.x branch October 13, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants