Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment OpenSearch Dashboards version to 2.0.0-rc1. #414

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Apr 15, 2022

Signed-off-by: dblock [email protected]

Description

Increment OpenSearch Dashboards version to 2.0.0-rc1.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team April 15, 2022 23:10
@kavilla
Copy link
Member

kavilla commented Apr 15, 2022

By keeping opensearchDashboardsVersion: 2.0.0, plugin owners can do development using the main branch of OpenSearch Dashboards since OpenSearch Dashboards sets this value to 2.0.0. This key-value lets OpenSearch Dashboards can properly install the plugin since it does a semvar + qualifier check on this value if they match then OpenSearch Dashboards proceeds to install it.

The build repo passes the qualifier while building OpenSearch Dashboards and plugins that automatically sets this value to build the correct version + qualifier. This allows a distribution to be made with value for opensearchDashboardsVersion be the expected value, for example opensearchDashboardsVersion: 2.0.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants