Remove unused functionality from Notifications frontend for initial r…

…elease (#377) * Remove Dashboard from sidenav Signed-off-by: Mohammad Qureshi <[email protected]> * Remove sent Notifications dashboard Signed-off-by: Mohammad Qureshi <[email protected]> * Remove 'Source' dropdown from Channels table Signed-off-by: Mohammad Qureshi <[email protected]> * Remove Availability section in Channel details Signed-off-by: Mohammad Qureshi <[email protected]> * Remove channel availability selection when creating a channel Signed-off-by: Mohammad Qureshi <[email protected]> * Remove notification source from channel item in Channels table Signed-off-by: Mohammad Qureshi <[email protected]> * Remove EventService and consolidate send test message logic into NotificationService Signed-off-by: Mohammad Qureshi <[email protected]> * Remove unusued routes for APIs Signed-off-by: Mohammad Qureshi <[email protected]> * Update failing jest tests and snapshots Signed-off-by: Mohammad Qureshi <[email protected]> * Remove stale snapshot file for ChannelAvailabilityPanel Signed-off-by: Mohammad Qureshi <[email protected]>
opensearch-project · Mar 15, 2022 · aa26e98 · aa26e98
1 parent 99baa27
commit aa26e98
Show file tree

Hide file tree

Showing 73 changed files with 453 additions and 6,591 deletions.
diff --git a/dashboards-notifications/common/index.ts b/dashboards-notifications/common/index.ts
@@ -16,7 +16,6 @@ export const NODE_API = Object.freeze({
   CREATE_CONFIG: `${NODE_API_BASE_PATH}/create_config`,
   DELETE_CONFIGS: `${NODE_API_BASE_PATH}/delete_configs`,
   UPDATE_CONFIG: `${NODE_API_BASE_PATH}/update_config`,
-  GET_EVENTS: `${NODE_API_BASE_PATH}/get_events`,
   GET_EVENT: `${NODE_API_BASE_PATH}/get_event`,
   GET_AVAILABLE_FEATURES: `${NODE_API_BASE_PATH}/features`,
   SEND_TEST_MESSAGE: `${NODE_API_BASE_PATH}/test_message`,

diff --git a/dashboards-notifications/models/interfaces.ts b/dashboards-notifications/models/interfaces.ts
@@ -9,25 +9,8 @@ import {
   CHANNEL_TYPE,
   ENCRYPTION_TYPE,
   NOTIFICATION_SOURCE,
-  SEVERITY_TYPE,
 } from '../public/utils/constants';
 
-export interface NotificationItem {
-  event_id: string;
-  created_time_ms: number;
-  last_updated_time_ms: number;
-  tenant?: string;
-  event_source: {
-    title: string;
-    reference_id: string;
-    feature: keyof typeof NOTIFICATION_SOURCE;
-    severity: keyof typeof SEVERITY_TYPE;
-    tags?: string[];
-  };
-  status_list: ChannelStatus[]; // could be multiple channels in a notification item
-  success: boolean; // calculated in the frontend based on status_list
-}
-
 export interface ChannelStatus {
   config_id: string;
   config_name: string;

diff --git a/dashboards-notifications/public/application.tsx b/dashboards-notifications/public/application.tsx
@@ -9,14 +9,13 @@ import { HashRouter as Router, Route } from 'react-router-dom';
 import { AppMountParameters, CoreStart } from '../../../src/core/public';
 import { CoreServicesContext } from './components/coreServices';
 import Main from './pages/Main';
-import { EventService, NotificationService } from './services';
+import { NotificationService } from './services';
 import { ServicesContext } from './services/services';
 
 export const renderApp = (coreStart: CoreStart, params: AppMountParameters) => {
   const http = coreStart.http;
   const notificationService = new NotificationService(http);
-  const eventService = new EventService(http);
-  const services = { notificationService, eventService };
+  const services = { notificationService };
 
   ReactDOM.render(
     <Router>

diff --git a/dashboards-notifications/public/models/interfaces.ts b/dashboards-notifications/public/models/interfaces.ts
@@ -4,9 +4,7 @@
  */
 
 import { NotificationService } from '../services';
-import EventService from '../services/EventService';
 
 export interface BrowserServices {
   notificationService: NotificationService;
-  eventService: EventService;
 }
diff --git a/dashboards-notifications/public/pages/Channels/Channels.tsx b/dashboards-notifications/public/pages/Channels/Channels.tsx
@@ -29,7 +29,6 @@ import { NotificationService } from '../../services';
 import {
   BREADCRUMBS,
   CHANNEL_TYPE,
-  NOTIFICATION_SOURCE,
   ROUTES,
 } from '../../utils/constants';
 import { getErrorMessage } from '../../utils/helpers';
@@ -95,16 +94,6 @@ export class Channels extends Component<ChannelsProps, ChannelsState> {
         truncateText: false,
         render: (type: string) => _.get(CHANNEL_TYPE, type, '-'),
       },
-      {
-        field: 'feature_list',
-        name: 'Notification source',
-        sortable: true,
-        truncateText: true,
-        render: (features: string[]) =>
-          features
-            .map((feature) => _.get(NOTIFICATION_SOURCE, feature, '-'))
-            .join(', ') || '-',
-      },
       {
         field: 'description',
         name: 'Description',
@@ -148,8 +137,6 @@ export class Channels extends Component<ChannelsProps, ChannelsState> {
     };
     if (state.filters.state != undefined)
       queryObject.is_enabled = state.filters.state;
-    if (!_.isEmpty(state.filters.source))
-      queryObject.feature_list = state.filters.source;
     return queryObject;
   }
 

diff --git a/dashboards-notifications/public/pages/Channels/__tests__/ChannelControls.test.tsx b/dashboards-notifications/public/pages/Channels/__tests__/ChannelControls.test.tsx
@@ -64,11 +64,6 @@ describe('<ChannelControls /> spec', () => {
     fireEvent.click(utils.getByText('Chime'));
     expect(onFiltersChange).toBeCalledWith({ type: ['email', 'chime'] });
 
-    fireEvent.click(utils.getByText('Source'));
-    fireEvent.click(utils.getByText('Alerting'));
-    fireEvent.click(utils.getByText('Reporting'));
-    expect(onFiltersChange).toBeCalledWith({ source: ['alerting', 'reports'] });
-
-    expect(onFiltersChange).toBeCalledTimes(5);
+    expect(onFiltersChange).toBeCalledTimes(3);
   });
 });
diff --git a/...notifications/public/pages/Channels/__tests__/__snapshots__/ChannelControls.test.tsx.snap b/...notifications/public/pages/Channels/__tests__/__snapshots__/ChannelControls.test.tsx.snap
@@ -121,44 +121,6 @@ exports[`<ChannelControls /> spec renders the component 1`] = `
           </button>
         </div>
       </div>
-      <div
-        class="euiPopover euiPopover--anchorDownCenter"
-      >
-        <div
-          class="euiPopover__anchor"
-        >
-          <button
-            class="euiButtonEmpty euiButtonEmpty--text euiFilterButton euiFilterButton--hasIcon euiFilterButton--noGrow"
-            type="button"
-          >
-            <span
-              class="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
-            >
-              <svg
-                aria-hidden="true"
-                class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
-                focusable="false"
-                height="16"
-                role="img"
-                viewBox="0 0 16 16"
-                width="16"
-                xmlns="http://www.w3.org/2000/svg"
-              />
-              <span
-                class="euiButtonEmpty__text"
-              >
-                <span
-                  class="euiFilterButton__textShift"
-                  data-text="Source"
-                  title="Source"
-                >
-                  Source
-                </span>
-              </span>
-            </span>
-          </button>
-        </div>
-      </div>
     </div>
   </div>
 </div>

diff --git a/...-notifications/public/pages/Channels/__tests__/__snapshots__/ChannelDetails.test.tsx.snap b/...-notifications/public/pages/Channels/__tests__/__snapshots__/ChannelDetails.test.tsx.snap
@@ -168,72 +168,6 @@ exports[`<ChannelDetails/> spec handles a non-existing channel 1`] = `
       style="padding: initial;"
     />
   </div>
-  <div
-    class="euiSpacer euiSpacer--l"
-  />
-  <div
-    class="euiPanel euiPanel--paddingMedium"
-    style="max-width: 1300px;"
-  >
-    <div
-      class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsCenter euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
-      style="padding: 0px 0px;"
-    >
-      <div
-        class="euiFlexItem"
-      >
-        <h3
-          class="euiTitle euiTitle--small"
-        >
-          Availability
-        </h3>
-      </div>
-    </div>
-    <hr
-      class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginSmall"
-    />
-    <div
-      style="padding: initial;"
-    >
-      <div>
-        <div
-          class="euiSpacer euiSpacer--s"
-        />
-        <div
-          class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--directionRow euiFlexGroup--responsive"
-        >
-          <div
-            class="euiFlexItem"
-          >
-            <dl
-              class="euiDescriptionList euiDescriptionList--row"
-              style="word-break: break-word; white-space: pre-line;"
-            >
-              <dt
-                class="euiDescriptionList__title"
-              >
-                Notification sources
-              </dt>
-              <dd
-                class="euiDescriptionList__description"
-              >
-                -
-              </dd>
-            </dl>
-          </div>
-          <div
-            class="euiFlexItem"
-          />
-          <div
-            class="euiFlexItem"
-          />
-        </div>
-        <div
-          class="euiSpacer euiSpacer--m"
-        />
-      </div>
-    </div>
-  </div>
 </div>
 `;
 
@@ -405,72 +339,6 @@ exports[`<ChannelDetails/> spec renders a specific channel 1`] = `
       style="padding: initial;"
     />
   </div>
-  <div
-    class="euiSpacer euiSpacer--l"
-  />
-  <div
-    class="euiPanel euiPanel--paddingMedium"
-    style="max-width: 1300px;"
-  >
-    <div
-      class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsCenter euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
-      style="padding: 0px 0px;"
-    >
-      <div
-        class="euiFlexItem"
-      >
-        <h3
-          class="euiTitle euiTitle--small"
-        >
-          Availability
-        </h3>
-      </div>
-    </div>
-    <hr
-      class="euiHorizontalRule euiHorizontalRule--full euiHorizontalRule--marginSmall"
-    />
-    <div
-      style="padding: initial;"
-    >
-      <div>
-        <div
-          class="euiSpacer euiSpacer--s"
-        />
-        <div
-          class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--directionRow euiFlexGroup--responsive"
-        >
-          <div
-            class="euiFlexItem"
-          >
-            <dl
-              class="euiDescriptionList euiDescriptionList--row"
-              style="word-break: break-word; white-space: pre-line;"
-            >
-              <dt
-                class="euiDescriptionList__title"
-              >
-                Notification sources
-              </dt>
-              <dd
-                class="euiDescriptionList__description"
-              >
-                -
-              </dd>
-            </dl>
-          </div>
-          <div
-            class="euiFlexItem"
-          />
-          <div
-            class="euiFlexItem"
-          />
-        </div>
-        <div
-          class="euiSpacer euiSpacer--m"
-        />
-      </div>
-    </div>
-  </div>
 </div>
 `;
 

diff --git a/...boards-notifications/public/pages/Channels/__tests__/__snapshots__/Channels.test.tsx.snap b/...boards-notifications/public/pages/Channels/__tests__/__snapshots__/Channels.test.tsx.snap
@@ -221,44 +221,6 @@ exports[`<Channels/> spec renders the empty component 1`] = `
               </button>
             </div>
           </div>
-          <div
-            class="euiPopover euiPopover--anchorDownCenter"
-          >
-            <div
-              class="euiPopover__anchor"
-            >
-              <button
-                class="euiButtonEmpty euiButtonEmpty--text euiFilterButton euiFilterButton--hasIcon euiFilterButton--noGrow"
-                type="button"
-              >
-                <span
-                  class="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
-                >
-                  <svg
-                    aria-hidden="true"
-                    class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
-                    focusable="false"
-                    height="16"
-                    role="img"
-                    viewBox="0 0 16 16"
-                    width="16"
-                    xmlns="http://www.w3.org/2000/svg"
-                  />
-                  <span
-                    class="euiButtonEmpty__text"
-                  >
-                    <span
-                      class="euiFilterButton__textShift"
-                      data-text="Source"
-                      title="Source"
-                    >
-                      Source
-                    </span>
-                  </span>
-                </span>
-              </button>
-            </div>
-          </div>
         </div>
       </div>
     </div>
@@ -480,37 +442,7 @@ exports[`<Channels/> spec renders the empty component 1`] = `
                 aria-live="polite"
                 aria-sort="none"
                 class="euiTableHeaderCell"
-                data-test-subj="tableHeaderCell_feature_list_3"
-                role="columnheader"
-                scope="col"
-              >
-                <button
-                  class="euiTableHeaderButton"
-                  data-test-subj="tableHeaderSortButton"
-                  type="button"
-                >
-                  <span
-                    class="euiTableCellContent"
-                  >
-                    <span
-                      class="euiTableCellContent__text"
-                      title="Notification source"
-                    >
-                      Notification source
-                    </span>
-                    <span
-                      class="euiScreenReaderOnly"
-                    >
-                      Click to sort in ascending order
-                    </span>
-                  </span>
-                </button>
-              </th>
-              <th
-                aria-live="polite"
-                aria-sort="none"
-                class="euiTableHeaderCell"
-                data-test-subj="tableHeaderCell_description_4"
+                data-test-subj="tableHeaderCell_description_3"
                 role="columnheader"
                 scope="col"
               >
@@ -544,7 +476,7 @@ exports[`<Channels/> spec renders the empty component 1`] = `
             >
               <td
                 class="euiTableRowCell euiTableRowCell--isMobileFullWidth"
-                colspan="6"
+                colspan="5"
               >
                 <div
                   class="euiTableCellContent euiTableCellContent--alignCenter"