Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed code coverage report #975

Conversation

martin-gaievski
Copy link
Member

Description

We need to re-enable cove coverage for this repo. At some point it got cancelled and stays like this for about 5-6 months.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski
Copy link
Member Author

@peterzhuamazon can you please help with this issue?
With these changes upload of codecov is failing with

[2024-11-06T01:12:03.492Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 1303s."}

https://github.com/opensearch-project/neural-search/actions/runs/11694952553/job/32570344238?pr=975#step:6:37

I was checking your PR codecov/feedback#525 and copied changes from opensearch-project/dashboards-flow-framework#401 to neural-search repo.

Before this change codecov action was failing with different issue: {"message":"Repository not found"} https://github.com/opensearch-project/neural-search/actions/runs/11616264178/job/32348813055?pr=971

@peterzhuamazon
Copy link
Member

I added CODECOV_TOKEN to your secret now.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 6, 2024

You need to merge this PR and check in another PR to see.
There might be more tweaks tho.

@yuye-aws
Copy link
Member

yuye-aws commented Nov 6, 2024

@martin-gaievski Can you confirm whether this is due to flakey tests?

@martin-gaievski
Copy link
Member Author

@martin-gaievski Can you confirm whether this is due to flakey tests?

it's different problem, not related to test logic.

@martin-gaievski martin-gaievski added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Nov 6, 2024
@martin-gaievski
Copy link
Member Author

You need to merge this PR and check in another PR to see. There might be more tweaks tho.

thank you Peter, let us merge, we'll see how it goes

@martin-gaievski martin-gaievski merged commit 0316dc4 into opensearch-project:main Nov 6, 2024
56 of 59 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 6, 2024
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 0316dc4)
martin-gaievski added a commit that referenced this pull request Nov 6, 2024
Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 0316dc4)

Co-authored-by: Martin Gaievski <[email protected]>
@martin-gaievski
Copy link
Member Author

@peterzhuamazon it may be the case we need additional tweaking for neural search, could you please take a look?

While some of the code coverage report uploads were successful after this PR (for instance this run: https://github.com/opensearch-project/neural-search/actions/runs/11714216506/job/32683862354), for other PRs it's still failing with Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 331s. (https://github.com/opensearch-project/neural-search/actions/runs/11731912261/job/32684320733?pr=977#step:6:36).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Infrastructure skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants