-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed code coverage report #975
Fixed code coverage report #975
Conversation
Signed-off-by: Martin Gaievski <[email protected]>
@peterzhuamazon can you please help with this issue?
I was checking your PR codecov/feedback#525 and copied changes from opensearch-project/dashboards-flow-framework#401 to neural-search repo. Before this change codecov action was failing with different issue: |
I added CODECOV_TOKEN to your secret now. |
You need to merge this PR and check in another PR to see. |
@martin-gaievski Can you confirm whether this is due to flakey tests? |
it's different problem, not related to test logic. |
thank you Peter, let us merge, we'll see how it goes |
0316dc4
into
opensearch-project:main
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 0316dc4)
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 0316dc4) Co-authored-by: Martin Gaievski <[email protected]>
@peterzhuamazon it may be the case we need additional tweaking for neural search, could you please take a look? While some of the code coverage report uploads were successful after this PR (for instance this run: https://github.com/opensearch-project/neural-search/actions/runs/11714216506/job/32683862354), for other PRs it's still failing with |
Signed-off-by: Martin Gaievski <[email protected]>
Description
We need to re-enable cove coverage for this repo. At some point it got cancelled and stays like this for about 5-6 months.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.