-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Advance Post Filter Integ Tests Scenarios #694
Add Advance Post Filter Integ Tests Scenarios #694
Conversation
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
BWC tests are failing because of #688 |
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/testFixtures/java/org/opensearch/neuralsearch/util/TestUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <[email protected]>
BWC tests are failing because of opensearch-project/ml-commons#2333 |
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/testFixtures/java/org/opensearch/neuralsearch/util/TestUtils.java
Outdated
Show resolved
Hide resolved
src/testFixtures/java/org/opensearch/neuralsearch/util/TestUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
============================================
+ Coverage 84.04% 84.42% +0.37%
- Complexity 744 750 +6
============================================
Files 59 59
Lines 2313 2324 +11
Branches 374 375 +1
============================================
+ Hits 1944 1962 +18
+ Misses 214 213 -1
+ Partials 155 149 -6 ☔ View full report in Codecov by Sentry. |
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryPostFilterIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-694-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86f6d4c62d02e953aa31d5d7a5b9716b93a3d8a2
# Push it to GitHub
git push --set-upstream origin backport/backport-694-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@vibrantvarun Can you do a manual backport PR to 2.x? Since this code change is causing other 2.x backport PR CI failure. |
Waiting for ml-commons PR to get merged |
* Add Advannce Post Filter Integ Tests Scenarios Signed-off-by: Varun Jain <[email protected]> * Reverting comment in HybridQueryPhaseSearcher Signed-off-by: Varun Jain <[email protected]> * Adding Martin Comments Signed-off-by: Varun Jain <[email protected]> * Adding Martin Comments Signed-off-by: Varun Jain <[email protected]> * Addressing Martin Comments Signed-off-by: Varun Jain <[email protected]> * Resolving conflicts Signed-off-by: Varun Jain <[email protected]> * Renaming Variables Signed-off-by: Varun Jain <[email protected]> * Addressing Martin Comments Signed-off-by: Varun Jain <[email protected]> * Addressing Martin Comments Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]>
* Add Advannce Post Filter Integ Tests Scenarios * Reverting comment in HybridQueryPhaseSearcher * Adding Martin Comments * Adding Martin Comments * Addressing Martin Comments * Resolving conflicts * Renaming Variables * Addressing Martin Comments * Addressing Martin Comments --------- Signed-off-by: Varun Jain <[email protected]>
Description
This PR contains following
Issue
#640
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.