Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download security keys only if -Dsecurity.enabled==true #680

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Apr 10, 2024

Description

Download security keys only if -Dsecurity.enabled = true.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vibrantvarun vibrantvarun merged commit ff95604 into opensearch-project:main Apr 10, 2024
64 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2024
* download security keys only if -Dsecurity.enabled==true

Signed-off-by: Varun Jain <[email protected]>

* Reverting HybridQueryPhaseSearchTests

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit ff95604)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2024
* download security keys only if -Dsecurity.enabled==true

Signed-off-by: Varun Jain <[email protected]>

* Reverting HybridQueryPhaseSearchTests

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit ff95604)
vibrantvarun added a commit that referenced this pull request Apr 10, 2024
* download security keys only if -Dsecurity.enabled==true

Signed-off-by: Varun Jain <[email protected]>

* Reverting HybridQueryPhaseSearchTests

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit ff95604)

Co-authored-by: Varun Jain <[email protected]>
vibrantvarun added a commit that referenced this pull request Apr 10, 2024
* download security keys only if -Dsecurity.enabled==true

Signed-off-by: Varun Jain <[email protected]>

* Reverting HybridQueryPhaseSearchTests

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit ff95604)

Co-authored-by: Varun Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch backport 2.13 skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants