Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error caching models in integ test #67

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

jmazanec15
Copy link
Member

Description

Fixes bug caching model load in integ test. This leads to a new model being loaded for each test. Now, only one model will be loaded, preventing CB exceptions.

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fixes bug caching model load in integ test. This leads to a new model
being loaded for each test. Now, only one model will be loaded,
preventing CB exceptions.

Signed-off-by: John Mazanec <[email protected]>
@jmazanec15 jmazanec15 requested a review from a team November 11, 2022 23:40
@jmazanec15 jmazanec15 added Infrastructure backport 2.4 backport 2.x Label will add auto workflow to backport PR to 2.x branch labels Nov 11, 2022
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmazanec15 jmazanec15 merged commit 6068858 into opensearch-project:main Nov 11, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2022
Fixes bug caching model load in integ test. This leads to a new model
being loaded for each test. Now, only one model will be loaded,
preventing CB exceptions.

Signed-off-by: John Mazanec <[email protected]>
(cherry picked from commit 6068858)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2022
Fixes bug caching model load in integ test. This leads to a new model
being loaded for each test. Now, only one model will be loaded,
preventing CB exceptions.

Signed-off-by: John Mazanec <[email protected]>
(cherry picked from commit 6068858)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch backport 2.4 Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants