-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GA to use latest JDK-21 #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
January 29, 2024 19:24
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
=========================================
Coverage 84.39% 84.39%
Complexity 535 535
=========================================
Files 40 40
Lines 1570 1570
Branches 245 245
=========================================
Hits 1325 1325
Misses 133 133
Partials 112 112 ☔ View full report in Codecov by Sentry. |
vibrantvarun
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @reta
martin-gaievski
added
the
backport 2.x
Label will add auto workflow to backport PR to 2.x branch
label
Jan 29, 2024
martin-gaievski
approved these changes
Jan 29, 2024
navneet1v
approved these changes
Jan 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 51f9d6f)
vibrantvarun
pushed a commit
to vibrantvarun/neural-search
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Andriy Redko <[email protected]>
This was referenced Jan 29, 2024
vibrantvarun
pushed a commit
to vibrantvarun/neural-search
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Varun Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update GA to use latest JDK-21
Issues Resolved
See please opensearch-project/OpenSearch#11968
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.